Fixed bug with task editing

Author: Ostap34PHP

app/Http/Controllers/TaskController.php

@@ -6,6 +6,7 @@
 use App\User;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Auth;
+use App\Http\Requests\UpdateUserTask;
 
 class TaskController extends Controller
 {
@@ -86,20 +87,13 @@ public function edit(Task $task)
      * @param  \Illuminate\Http\Request  $request
      * @return \Illuminate\Http\Response
      */
-    public function update($id, Request $request)
+    public function update($id, UpdateUserTask $request)
     {    
-        $task = new Task;
-        if($task->user_id == Auth::id()){
-            $data = $this->validate(request(), [
-            'name'        => 'required|max:150;',
-            'description' => ''
-            ]);
-
-            $data['id'] = $id;
-        
-            $task->updateTask($data);
-            return back()->with('success', 'task has been updated');
-        }        
+        $task = Task::findOrFail($id);
+        if($request->user_id == Auth::id()){
+            $task->update($request->all());
+        }
+        return back()->with('success', 'task has been updated');
     }
 
     /**

app/Http/Requests/UpdateUserTask.php

@@ -0,0 +1,33 @@
+<?php
+
+namespace App\Http\Requests;
+
+use Illuminate\Foundation\Http\FormRequest;
+use Illuminate\Support\Facades\Auth;
+
+
+class UpdateUserTask extends FormRequest
+{
+    /**
+     * Determine if the user is authorized to make this request.
+     *
+     * @return bool
+     */
+    public function authorize()
+    {
+        return true;
+    }
+
+    /**
+     * Get the validation rules that apply to the request.
+     *
+     * @return array
+     */
+    public function rules()
+    {
+        return [
+            'name'        => 'required|max:150;',
+            'description' => '',
+        ];
+    }
+}

app/Task.php

@@ -7,13 +7,4 @@
 class Task extends Model
 {
     protected $fillable = ['name','description','user_id'];
-
-    public function updateTask($data)
-    {
-        $task = $this->find($data['id']);
-        $task->name = $data['name'];
-        $task->description = $data['description'];
-        $task->save();
-        return 1;
-    }
 }