allow more generic array types in list_matrices #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jfbischoff this seems quite reasonable, thanks for the PR! I need to run the tests (uhhhhhhr not very many of those it seems), and if nothing weird is broken, I'll merge this shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
To improve interoperability, this PR updates list_matrices() to detect any 2D tables.Array, not just the specific CArray type.
The OMX specification doesn't mandate a CArray, so this change brings the library into closer alignment with the spec and allows it to seamlessly read files created by a wider range of HDF5 tools, such as https://github.com/jamesmudd/jhdf .
Thanks for your consideration!