chore(popx): code simplification and refactoring #816
+70
−484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepatrik
commented
Oct 7, 2024
| if len(legacyVersion) > 14 { | ||
| legacyVersion = legacyVersion[:14] | ||
| } | ||
| err := c.RawQuery(fmt.Sprintf("SELECT version FROM %s WHERE version IN (?, ?)", mtn), mi.Version, legacyVersion).All(&appliedMigrations) |
There was a problem hiding this comment.
We've now combined two queries into one, which should half the number of queries and (depending on the database) can significantly improve the performance of the migrate job.
| if m.Connection.Dialect.Name() == "cockroach" { | ||
| outer := fn | ||
| fn = func() error { | ||
| return crdb.Execute(outer) |
There was a problem hiding this comment.
From the documentation of crdb.Execute:
It is used to add retry handling to the execution of a single statement. If a multi-statement transaction is being run, use ExecuteTx instead.
But as the transaction is started within, we don't need to retry anything at this point.
| ) | ||
|
|
||
| //go:embed stub/migrations/transactional/*.sql | ||
| var transactionalMigrations embed.FS | ||
|
|
||
| func TestMigratorUpgrading(t *testing.T) { |
There was a problem hiding this comment.
This test was mostly skipped anyway, and I removed the "legacy" migrator with this PR, so no need to test compatibility anymore.
aeneasr
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging the migrator, I stumbled upon a couple of improvements that could be made.
I also removed the pkgerx package, as we don't use that now for years.