Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support working with query string and JSON body #964

Closed
3 of 6 tasks
renom opened this issue May 18, 2022 · 7 comments
Closed
3 of 6 tasks

Support working with query string and JSON body #964

renom opened this issue May 18, 2022 · 7 comments
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.

Comments

@renom
Copy link

renom commented May 18, 2022

Preflight checklist

Describe your problem

Support working with query string and JSON body

Describe your ideal solution

  1. Mutating and hydrating query string and JSON body (e.g. adding/replacing/removing a query string parameter or a JSON body path)
  2. Extracting data from query string and JSON body for keto_engine_acp_ory (e.g. data from a query string parameter or a JSON body path)
  3. Support autherizer rules for query string parameters and JSON body paths (e.g. allowing or disallowing specific values)

Workarounds or alternatives

Version

Additional Context

No response

@renom renom added the feat New feature or request. label May 18, 2022
@omerlh
Copy link
Contributor

omerlh commented Sep 18, 2022

Any updates on that? It seems like #843 is related to this.
We are more interesting in query params right now, will a PR will be accepted here?

@omerlh
Copy link
Contributor

omerlh commented Sep 20, 2022

I found a workaround for query params:

{{ .MatchContext.URL.Query.Get \"a\" }}

No code change is requires in oathkeeper to support it, just the power of Go templates 💪

@ViswanathB
Copy link

I found a workaround for query params:

{{ .MatchContext.URL.Query.Get \"a\" }}

No code change is requires in oathkeeper to support it, just the power of Go templates muscle

Like this idea: @omerlh Did you find any issues with this at scale?

@omerlh
Copy link
Contributor

omerlh commented Nov 9, 2022

Nope, this working pretty well for us

@denysandriyanov
Copy link

Have you had a chance to get the way how to extract some values from original request body?

@omerlh
Copy link
Contributor

omerlh commented Sep 18, 2023

If you use the remote authorizer the full request body is sent to this service so you can use the request body for authZ. We built a small service that handle authZ so it also handles this part.

Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas on how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

4 participants