Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification code loop #247

Closed
3 tasks
Big-Brother-Man opened this issue Feb 16, 2023 · 1 comment
Closed
3 tasks

Verification code loop #247

Big-Brother-Man opened this issue Feb 16, 2023 · 1 comment
Labels
stale Feedback from one or more authors is required to proceed.

Comments

@Big-Brother-Man
Copy link

Big-Brother-Man commented Feb 16, 2023

Discussed in https://github.com/orgs/ory/discussions/50

Hi all, I have been struggling with an issue for a while. Turns out the documentation has not been updated. The complete verification flow currently, does not show both code and link but just link for instance. It also does not take code part of its body.

image

If a user follows the above they would not be able to complete verification flow. Instead they would need to include code part of the body as shown as bellow.

   const verify = {
           flow: data.flowId,
           updateVerificationFlowBody: {
               method: "code",
               email: "test@gmail.com",
               csrf_token: data.csrf,
               code: data.code
           },
       }

Would love to update the document to reflect the current way ORY consumes and completes flow instead of what is there which does not take code (but user would make a judgment call thinking token == code which is not the case).

  • Update the updateVerificationFlowBody to contain code property
  • Update the document to contain both link and code to be available now
  • Update @Ory/Client to propagate the changes.
@aeneasr aeneasr transferred this issue from ory/.github Feb 16, 2023
Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas on how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

1 participant