Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have dsn: memory as an alias for SQLite in memory DSN #228

Closed
aeneasr opened this issue Feb 3, 2020 · 3 comments · Fixed by #284
Closed

Have dsn: memory as an alias for SQLite in memory DSN #228

aeneasr opened this issue Feb 3, 2020 · 3 comments · Fixed by #284
Assignees
Labels
feat New feature or request.

Comments

@aeneasr
Copy link
Member

aeneasr commented Feb 3, 2020

Is your feature request related to a problem? Please describe.

SQLite supports memory with sqlite://foo.db?mode=memory&_fk=true. Using dsn: memory should be an alias for that.

@aeneasr aeneasr added feat New feature or request. up for grab labels Feb 3, 2020
@aeneasr aeneasr added this to the v0.2.0-alpha.1 milestone Feb 3, 2020
@zepatrik
Copy link
Member

zepatrik commented Mar 2, 2020

The current setup in the quickstart is not working with an in-memory db. Having a container that does the migration and a different one running kratos those two do not share memory (and thus the db has no migrations). I think with the memory alias we should also apply migrations automatically.

@zepatrik
Copy link
Member

zepatrik commented Mar 2, 2020

Also the sqlite docs say one should use the file :memory: but in fact both URIs work:

  1. sqlite://:memory:?_fk=true
  2. sqlite://?mode=memory&_fk=true

Which one should we use?

@aeneasr
Copy link
Member Author

aeneasr commented Mar 2, 2020 via email

aeneasr added a commit that referenced this issue Mar 16, 2020
Closes #228

Co-authored-by: aeneasr <aeneas@ory.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants