fix: issue #4043 | Ory hydra altering scopes in JWT token claims when scope containing pipes #4045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…requested scope contains a pipe '|'
|
|
… simplify test to focus on scope preservation
…d defaults - Modified acceptLoginHandler to accept any RequestedScope instead of asserting hardcoded default scopes - Modified acceptConsentHandler to grant requested scopes verbatim (GrantScope: rr.RequestedScope) instead of hardcoded defaults - This allows scopes containing pipe characters (e.g., patient|read) to be preserved through the OAuth2 flow - Enables FHIR OAuth2 compliance and ONC g(10) certification support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug fix for #4043
Ory hydra altering scopes in JWT token claims when requested scope contains a pipe '|'
Issue : when scopes contains pipe '|' while executing auth code workflow (using client secret post) , example scopes :
openid offline_access abc|def
JWT token response from hydra provides scope list (claims) as "openid", "offline_access", "abc" ,"def"
its a bug , ideally hydra should return original scopes back in response.
root cause of the issue,
while generating login challenge , hydra storing the scopes (coming from request via space saparete), hydra storing these scope in table via pipe separate. i.e if request coming with scopes :
"openid offline_access abc|def"
hydra storing them with pipe separate as requested scopes:
'openid|offline_access|abc|def'