Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow injecting extra fosite strategies #3646

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Oct 12, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl self-assigned this Oct 12, 2023
@hperl hperl force-pushed the hperl/rop-grant branch 2 times, most recently from 7d5307c to 815e82e Compare October 12, 2023 11:26
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #3646 (6d1aecc) into master (cde3a30) will decrease coverage by 0.14%.
Report is 2 commits behind head on master.
The diff coverage is 60.00%.

❗ Current head 6d1aecc differs from pull request most recent head 7e4cb0f. Consider uploading reports for the commit 7e4cb0f to get more accurate results

@@            Coverage Diff             @@
##           master    #3646      +/-   ##
==========================================
- Coverage   76.17%   76.03%   -0.14%     
==========================================
  Files         132      133       +1     
  Lines       10030    10091      +61     
==========================================
+ Hits         7640     7673      +33     
- Misses       1874     1891      +17     
- Partials      516      527      +11     
Files Coverage Δ
client/manager_test_helpers.go 98.49% <100.00%> (ø)
driver/registry.go 23.52% <ø> (ø)
driver/registry_base.go 84.58% <100.00%> (+0.26%) ⬆️
fositex/config.go 86.30% <100.00%> (+0.19%) ⬆️
persistence/sql/persister.go 85.54% <ø> (ø)
persistence/sql/persister_client.go 84.44% <100.00%> (ø)
persistence/sql/persister_authenticate.go 0.00% <0.00%> (ø)
driver/config/provider.go 78.54% <0.00%> (-0.79%) ⬇️
driver/factory.go 46.87% <25.00%> (-1.46%) ⬇️

... and 5 files with indirect coverage changes

@hperl hperl force-pushed the hperl/rop-grant branch 3 times, most recently from 0397928 to fbc068a Compare October 12, 2023 19:07
@hperl hperl marked this pull request as ready for review October 13, 2023 07:30
@hperl hperl requested a review from aeneasr as a code owner October 13, 2023 07:30
oauth2/handler.go Outdated Show resolved Hide resolved
This will allow resource owner password grants to authenticate
againts a Kratos user pool.

Note that we still recommend agains using the resource owner password
grant and will not support it by default in Hydra.
@aeneasr aeneasr merged commit 88b0b7c into master Oct 17, 2023
28 of 29 checks passed
@aeneasr aeneasr deleted the hperl/rop-grant branch October 17, 2023 08:43
@@ -643,7 +643,7 @@ GetOidcUserInfo OpenID Connect Userinfo
This endpoint returns the payload of the ID Token, including `session.id_token` values, of
the provided OAuth 2.0 Access Token's consent request.

In the case of authentication error, a WWW-Authenticate header might be set in the response

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find and replace gone wrong ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants