Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlData struct PK field should be an int64 #1595

Closed
pike1212 opened this issue Oct 7, 2019 · 1 comment
Closed

sqlData struct PK field should be an int64 #1595

pike1212 opened this issue Oct 7, 2019 · 1 comment
Milestone
v1.1.0

Comments

@pike1212
Copy link
Contributor

pike1212 commented Oct 7, 2019 •
edited
Loading

Describe the bug

The sqlData struct PK field is declared as an int, but is actually an int64 in Cockroach DB

Reproducing the bug

Run make test with a 32 bit version of Go

Server logs

sql: Scan error on column index 23, name "pk": converting driver.Value type int64 ("492838020877385729") to a int: value out of range
@aeneasr
Copy link
Member

aeneasr commented Oct 8, 2019

Oh yeah this should be a 64bit integere. Would you be up for a PR?

@aeneasr aeneasr added this to the v1.1.0 milestone Oct 8, 2019
@pike1212 pike1212 mentioned this issue Oct 8, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
2 participants
@aeneasr @pike1212