-
Notifications
You must be signed in to change notification settings - Fork 407
docs: update react quickstart example #2085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aeneasr not sure I understand. Does not look broken. Unless you are referring to something else |
Ah nevermind. I see it now |
Fixed here: #2104 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay - LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @christiannwamba, what a nice upgrade to the guide!
I tried to follow it "braindead", basically just copying and pasting the commands and following the written instructions.
I think its really important that the guide works if you do it this way without any issues - as soon as you have some little error people already get frustrated.
See my comments in that light - I think it just needs to be super smooth, so please be as specific as possible and have everything in a copy&paste-able state
it's 95% there, just need to smooth out a few small things!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, there are only a few minor things. Otherwise I could get the tutorial to work for me! Once those are resolved I think we can merge this! :)
88a7782
to
17ad610
Compare
Co-authored-by: Jonas Hungershausen <jonas.hungershausen@ory.sh>
Co-authored-by: Jonas Hungershausen <jonas.hungershausen@ory.sh>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
17ad610
to
f93e35c
Compare
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments