Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs should make the button tag optional for tabitems #162

Closed
mat813 opened this issue Jun 25, 2021 · 2 comments · Fixed by #177
Closed

Tabs should make the button tag optional for tabitems #162

mat813 opened this issue Jun 25, 2021 · 2 comments · Fixed by #177
Assignees
@astagi
Labels
enhancement Improvements to existing features and functionality question Further information is requested

Comments

@mat813
Copy link

mat813 commented Jun 25, 2021

Description

Tabs should make the button tag optional for tabitems.

Why Oruga need this feature

Right now, there is no way to change the default tag, even when using the header slot.
Some css frameworks, like, say, Bulma, are much more cute when using a a tag instead.
@jtommy
Copy link
Member

jtommy commented Jun 25, 2021 •
edited
Loading

Why do you need a element?
About accessibility button should be better than a but I might add a new prop tag as I did with dropdown-item component

@jtommy jtommy added the question Further information is requested label Jun 25, 2021
@astagi astagi added the enhancement Improvements to existing features and functionality label Aug 9, 2021
@astagi astagi self-assigned this Aug 9, 2021
@astagi astagi mentioned this issue Aug 9, 2021
Merged
@astagi
Copy link
Member

astagi commented Aug 9, 2021

@mat813 PR #177 should satisfy your request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astagi astagi

Labels
enhancement Improvements to existing features and functionality question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for tag in TabsItem oruga-ui/oruga
3 participants
@mat813 @astagi @jtommy