Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whether OroCRM really needs the «Wind Speed Unit» and «Temperature Unit» options? #274

Open
dmitrii-fediuk opened this issue May 23, 2017 · 2 comments
Labels

Comments

@dmitrii-fediuk
Copy link

01

@mkudelya
Copy link
Contributor

Hi

These units are used by google maps.

@dmitrii-fediuk
Copy link
Author

By why is this code block in a CRM at all?

if (this.options.showWeather) {
	var temperatureUnitKey = localeSettings.settings.unit.temperature.toUpperCase();
	var windSpeedUnitKey = localeSettings.settings.unit.wind_speed.toUpperCase();
	weatherLayer = new google.maps.weather.WeatherLayer({
		temperatureUnits: google.maps.weather.TemperatureUnit[temperatureUnitKey],
		windSpeedUnits: google.maps.weather.WindSpeedUnit[windSpeedUnitKey]
	});
	weatherLayer.setMap(this.map);

	cloudLayer = new google.maps.weather.CloudLayer();
	cloudLayer.setMap(this.map);
}

https://github.com/orocrm/platform/blob/2.1.2/src/Oro/Bundle/AddressBundle/Resources/public/js/mapservice/googlemaps.js#L79-L90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants