Skip to content

Commit c07a5c2

Browse files
authored
Merge pull request WildCodeSchool#56 from WildCodeSchool/dev
Dev
2 parents d598717 + f2cb891 commit c07a5c2

File tree

12 files changed

+73
-266
lines changed

12 files changed

+73
-266
lines changed

CHANGELOG.md

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,21 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10-
Nothing planned right now.
10+
## [3.0.0] - 2023-05-29
11+
12+
### Added
13+
14+
- Git commands for Windows users, to fix issues with different newline formats (see [README.md](README.md#windows-users)).
15+
16+
### Changed
17+
18+
- Changed default ports configuration to 3000 for frontend and 6000 for backend. Thanks to [Loris Chastanet](https://github.com/lchastanet).
19+
20+
- **Breaking change:** removed cutomized alias for imports in frontend.
21+
22+
### Fixed
23+
24+
- Moved `vite` `and `@`vitejs/plugin-react` as regular dependencies in frontend, and fixed imports in config. Thanks to [Pierre Paillard](https://github.com/PPaillard/).
1125

1226
[Open an issue](https://github.com/WildCodeSchool/js-template-fullstack/issues/new) if you have any request/feedback :)
1327

README.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,15 @@ It's pre-configured with a set of tools which'll help students produce industry-
55

66
## Setup & Use
77

8+
### Windows users
9+
10+
Be sure to run these commands in a git terminal to avoid [issues with newline formats](https://en.wikipedia.org/wiki/Newline#Issues_with_different_newline_formats):
11+
12+
```
13+
git config --global core.eol lf
14+
git config --global core.autocrlf false
15+
```
16+
817
### Project Initialization
918

1019
- In VSCode, install plugins **Prettier - Code formatter** and **ESLint** and configure them

backend/.env.sample

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
APP_PORT=5000
1+
APP_PORT=6000
22
FRONTEND_URL=http://localhost:3000
33
DB_HOST=localhost
44
DB_PORT=3306

backend/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ require("dotenv").config();
22

33
const app = require("./src/app");
44

5-
const port = parseInt(process.env.APP_PORT ?? "5000", 10);
5+
const port = parseInt(process.env.APP_PORT ?? "6000", 10);
66

77
app.listen(port, (err) => {
88
if (err) {

frontend/.env.sample

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# call it in React with import.meta.env.VITE_BACKEND_URL
2-
VITE_BACKEND_URL=http://localhost:5000
2+
VITE_BACKEND_URL=http://localhost:6000

frontend/.eslintrc.json

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -34,18 +34,5 @@
3434
"assert": "either"
3535
}
3636
]
37-
},
38-
"settings": {
39-
"import/resolver": {
40-
"eslint-import-resolver-custom-alias": {
41-
"alias": {
42-
"@assets": "./src/assets",
43-
"@components": "./src/components",
44-
"@pages": "./src/pages",
45-
"@services": "./src/services"
46-
},
47-
"extensions": [".js", ".jsx"]
48-
}
49-
}
5037
}
5138
}

frontend/jsconfig.json

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)