PR Review Comments Unresolvable By Owner of Review #8327
Replies: 2 comments
-
just a comment .... To make it even more weird: |
Beta Was this translation helpful? Give feedback.
-
Agreed such a feature would be really helpful. Unable to resolve review items on my own creates a lot of noise in the comments and it is difficult to navigate through the conversation. Many times there are multiple unresolved reviews that have been addressed and should be in the resolved state but require the intervention of someone with write access to the repo which makes reviewing tedious. |
Beta Was this translation helpful? Give feedback.
-
From the github documentation at https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews:
You can resolve a conversation in a pull request if you opened the pull request or if you have write access to the repository where the pull request was opened.
As a collaborator with triage permissions and maintainer of an open source project, I should be able to resolve my own review items even though I do not have write access to the repository. I can delete my own review items, edit them, etc., so it follows that I should be able to resolve my own review items.
Example of needing member with read/ write access to resolve items: checkstyle/checkstyle#10990 (review)
To me - having the ability to delete review items where there could be discussion from other contributors and organization members has the potential to be much more destructive than simply resolving my own review items.
Beta Was this translation helpful? Give feedback.
All reactions