Upgrade to node16 #243
Merged
Upgrade to node16 #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @samwho |
|
Hey @orgoro thanks for getting to this so quickly! I had noticed the CI run failed and was planning to look in to it after a few meetings, but you beat me to it. Any idea what the problem is? The error is a little cryptic. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub have deprecated Node12 and plan to have all actions running on Node16 by summer 2023 (https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/).
This PR sets
action.usestonode16, and also takes the liberty to upgrade the repo's own test workflow toactions/checkout@v3, as@v2is also slated for deprecation. 🙂I'm not sure what release process exists for this action, but I'm happy to help out further to get this released before the deadline.