RFC: Fixes clase 1 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,7 +34,13 @@ | |||
| # + | |||
| import pandas as pd | |||
|
|
|||
| df = pd.read_csv('../../datasets/superheroes.csv') | |||
| GSPREADHSEET_DOWNLOAD_URL = ( | |||
There was a problem hiding this comment.
Agregaría un comentario indicando la forma "fácil" directo de un path como para que les quede en el notebook, onda
# Para cargar un archivo csv a partir de una ruta
# df = pd.read_csv('../../datasets/superheroes.csv')
# Para cargar un archivo desde Google Sheets
<continuación>There was a problem hiding this comment.
Sino, en lugar de cargarlo desde gsheets podriamos descargarlo y leerlo de esta ultima forma?
There was a problem hiding this comment.
Dale, podemos decir eso tambien
| @@ -328,14 +390,19 @@ def alignment_to_numeric(alignment): | |||
| # | |||
| # Usamos un dataset que registra el clima y demás datos para distintas fechas de [alquiler de bicicletas](https://www.kaggle.com/c/bike-sharing-demand/data?select=train.csv) | |||
|
|
|||
| bicis_df = pd.read_csv('../datasets/bicis.csv').set_index('datetime') | |||
| bicis_df = pd.read_csv( | |||
There was a problem hiding this comment.
Acá haría lo mismo que para el dataset de superheroes o aclararía en un comentario que otra forma es leer el archivo directo desde Google Sheets como para que no se asusten cuando vean esto
Co-authored-by: CrossNox <ijmermet@gmail.com>
Co-authored-by: CrossNox <ijmermet@gmail.com>
Fixed datetime range loc
sofiamorseletto
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raises-exceptiona las celdas que tiran excepcionCierra #21 (en teoria)