Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

Cannot load the .eds files - No CANopen + .eds parse functionality #86

Open
klausz opened this issue Jun 27, 2023 · 4 comments
Open

Cannot load the .eds files - No CANopen + .eds parse functionality #86

klausz opened this issue Jun 27, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@klausz
Copy link

klausz commented Jun 27, 2023

Describe the bug
Cannot load the .eds files

To Reproduce
Steps to reproduce the behavior:
Having two different *.eds files in
../.cache/canopen_monitor when
starting the program:
canon-monitor -I vcan0
an error message comes up:

canopen-monitor/__main.py__ line 70
canopen-monitor/parse/eds.py line 360
canopen-monitor/parse/eds.py line 340
canopen-monitor/parse/eds.py line 308
canopen-monitor/parse/eds.py line 156
key, value = e.split('=')
ValueError: not enough values to unpack (expected 2 got 1).

Expected behavior
There should be no error. (On another PC there is no error message but eds parsing is not working

Environment (please complete the following information):
Ubuntu 22.04

Additional context
As side issue: Unfortunately on two different Ubuntu Linux PCs I never has the eds funktionality CANopen Data with Parsed EDS Data working)
Bildschirmfoto 2023-06-27 um 10 36 06

@klausz klausz added the bug Something isn't working label Jun 27, 2023
@dmitri-mcguckin dmitri-mcguckin self-assigned this Jun 28, 2023
@dmitri-mcguckin
Copy link
Member

dmitri-mcguckin commented Jul 2, 2023

@klausz Just wanted to give an update.

I've not been able to replicate this behavior but I have an intuition of where it's coming from. (Likely the lib we're using to have a file-select window for loading OD files).

That said, OreSat does have some other priorities at the moment in preparation for OreSat0.5, so I do apologize if this takes a bit before I can find and solve the problem.

@klausz
Copy link
Author

klausz commented Jul 26, 2023

Declaration of Node + EDS
As a side question (prio low as there are other priorities):

  • suppose we have CANopen data coming in (CANplayer). Also
  • we have, lets say, min 2 CANopen nodes with .eds/.dbc files.
    -> where and how is the declaration of the individual node (that must be done additional to the corresponding CANopen data) with the *.eds file done?
    Seeing Christian Sandberg, CANopen maybe similar to this:
network.connect (bustype = 'socketcan', channel='vcan0')
node0x3 = CANopen.Remote_Node(3, 'e35.eds')
network.add_node(0x3)  

Best would be when i can test this incrementally with Jupyter Notebooks.
Maybe there is an already existing test script where the information can be taken from. (Or a Video seeing how it works).

@ryanpdx
Copy link
Member

ryanpdx commented Nov 9, 2023

I encountered this same bug. I was able t figure out it came from putting a comment before an object definition

...

;comment
[1000]
...

@klausz
Copy link
Author

klausz commented Nov 16, 2023

@ryanpdx, I tried to test again but without success (as i had no 'comment' entries).
Nevertheless you had it working.
It would be good to have a very 'narrow' application working. There we need an .eds (or .dcf) and a .log file. Any idea from you or others? When this minimum solution is working each one can start to increase the data input and nail down the errors.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants