Skip to content

Conversation

@talek
Copy link
Contributor

@talek talek commented Mar 24, 2025

PR #504 is breaking some of my playbooks:

TASK [opitzconsulting.ansible_oracle.oradb_manage_db : manage_db | Add change-pdb script] ***                                                                                                       
fatal: [moo]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'scripts_folder' is undefined. 'scripts_folder' is undefined\n\nThe error appears to be in 
'/Users/talek/.ansible/collections/ansible_collections/opitzconsulting/ansible_oracle/roles/oradb_manage_db/tasks/main.yml': line 65, column 3, but may\nbe elsewhere in the file depending on the e
xact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: manage_db | Add change-pdb script\n  ^ here\n"}                                                                              

The reason is that the new scripts_folder variable is defined in the common role which is not a dependent role for any of the oradb_manage_db nor oraswdb_install roles. A better place to have this variable defined is orahost_meta. This PR addresses this issue.

@Rendanic Rendanic added the bug label Mar 30, 2025
@Rendanic Rendanic added this to the 4.13 milestone Mar 30, 2025
@Rendanic Rendanic merged commit d1c121a into oravirt:master Mar 30, 2025
5 of 6 checks passed
Rendanic added a commit to Rendanic/ansible-oracle that referenced this pull request Mar 30, 2025
v4.13.0
=======

Minor Changes
-------------

- Added a guide on how to install Ansible-Oracle manually on a server without Internet access. (oravirt#506)
- Fix typo for sql_zauberkasten (oravirt#509)
- ansible-lint: more excludes (oravirt#505)
- create OMF enabled databases using dbca's -useOMF flag (oravirt#507)
- manage_pdb: Enter nested loop only when oracle_pdbs has an entry (oravirt#507)
- oraapex: Added missing option to copy source from remote or local host (oravirt#512)
- oradb_manage_db: make hard coded folder .Scripts configurable (oravirt#511)
- oradb_tzupgrade: Add orasw_meta_internal as a dependent role (oravirt#510)

Bugfixes
--------

- orahost_meta: move scripts_folder variable from common to orahost_meta (oravirt#504)
@Rendanic Rendanic mentioned this pull request Mar 30, 2025
Rendanic added a commit that referenced this pull request Mar 30, 2025
v4.13.0
=======

Minor Changes
-------------

- Added a guide on how to install Ansible-Oracle manually on a server without Internet access. (#506)
- Fix typo for sql_zauberkasten (#509)
- ansible-lint: more excludes (#505)
- create OMF enabled databases using dbca's -useOMF flag (#507)
- manage_pdb: Enter nested loop only when oracle_pdbs has an entry (#507)
- oraapex: Added missing option to copy source from remote or local host (#512)
- oradb_manage_db: make hard coded folder .Scripts configurable (#511)
- oradb_tzupgrade: Add orasw_meta_internal as a dependent role (#510)

Bugfixes
--------

- orahost_meta: move scripts_folder variable from common to orahost_meta (#504)
@talek talek deleted the scripts_folder_fix branch June 4, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants