Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set go version to 1.22.0 in go.mod #1351

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

Amulyam24
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1350

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@shizhMSFT
Copy link
Contributor

@Amulyam24 The checks are failing due to

go: module ../../../.. listed in go.work file requires go >= 1.22.0, but go.work lists go 1.22; to update it:

I guess you need to update the following files:

@Amulyam24
Copy link
Contributor Author

@Amulyam24 The checks are failing due to

go: module ../../../.. listed in go.work file requires go >= 1.22.0, but go.work lists go 1.22; to update it:

I guess you need to update the following files:

Hi @shizhMSFT. Addressed it, PTAL!

Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 28c8514 into oras-project:main Apr 16, 2024
6 checks passed
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.49%. Comparing base (8b5c576) to head (1bbb958).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1351   +/-   ##
=======================================
  Coverage   84.49%   84.49%           
=======================================
  Files         103      103           
  Lines        3677     3677           
=======================================
  Hits         3107     3107           
  Misses        340      340           
  Partials      230      230           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shizhMSFT shizhMSFT changed the title set go version to 1.22.0 in go.mod chore: set go version to 1.22.0 in go.mod Apr 16, 2024
@Amulyam24 Amulyam24 deleted the go-toolchain branch April 16, 2024 14:17
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oras build fails with go toolchain not available
2 participants