Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable referrers index GC by default #1059

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Aug 9, 2023

Resolves #1041, depends on #1059

qweeah added 2 commits August 9, 2023 06:56
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #1059 (9ac52ef) into main (ceb56f8) will decrease coverage by 0.36%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
- Coverage   81.26%   80.90%   -0.36%     
==========================================
  Files          57       56       -1     
  Lines        2914     2891      -23     
==========================================
- Hits         2368     2339      -29     
- Misses        373      377       +4     
- Partials      173      175       +2     
Files Changed Coverage Δ
cmd/oras/internal/errors/errors.go 100.00% <ø> (ø)
cmd/oras/internal/option/remote.go 77.59% <100.00%> (+0.12%) ⬆️
cmd/oras/root/attach.go 82.50% <100.00%> (-2.99%) ⬇️
cmd/oras/root/cp.go 86.36% <100.00%> (-0.50%) ⬇️
cmd/oras/root/manifest/push.go 72.86% <100.00%> (-2.89%) ⬇️

@qweeah
Copy link
Contributor Author

qweeah commented Aug 9, 2023

Closing to separate into 2 PRs.

@qweeah qweeah closed this Aug 9, 2023
@qweeah qweeah reopened this Aug 9, 2023
@qweeah qweeah changed the title feat: remove --skip-delete-referrers and disable GC by default feat: disable referrers index GC by default Aug 9, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing the --skip-delete-referrers
3 participants