Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix the links in project readme #1012

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Conversation

amands98
Copy link
Contributor

@amands98 amands98 commented Jul 8, 2023

This PR fixes the links. Fixes #1017

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

README.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2023

Codecov Report

Merging #1012 (9010a0d) into main (5194c2e) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1012      +/-   ##
==========================================
+ Coverage   80.97%   81.04%   +0.06%     
==========================================
  Files          57       57              
  Lines        2907     2907              
==========================================
+ Hits         2354     2356       +2     
+ Misses        378      376       -2     
  Partials      175      175              

see 1 file with indirect coverage changes

@qweeah qweeah changed the title [chore] fix the links in project readme chore: fix the links in project readme Jul 10, 2023
Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@qweeah
Copy link
Contributor

qweeah commented Jul 11, 2023

LGTM but @amands98 can you help rebase the PR to main branch, thanks.

amands98 and others added 3 commits July 12, 2023 08:30
This PR fixes the links.

Signed-off-by: Aman <136564604+amands98@users.noreply.github.com>
Signed-off-by: Aman <136564604+amands98@users.noreply.github.com>
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Aman <136564604+amands98@users.noreply.github.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 46780e7 into oras-project:main Jul 12, 2023
@amands98
Copy link
Contributor Author

First PR merged, more to come.

qweeah pushed a commit to qweeah/oras that referenced this pull request Jul 21, 2023
Signed-off-by: Aman <136564604+amands98@users.noreply.github.com>
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah pushed a commit to qweeah/oras that referenced this pull request Jul 21, 2023
Signed-off-by: Aman <136564604+amands98@users.noreply.github.com>
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Signed-off-by: Aman <136564604+amands98@users.noreply.github.com>
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Broken Links] The "contributing to ORAS" and "development guide" in the readme are broken links
5 participants