Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X509 Authentication with OCI registry #491

Closed
catric333 opened this issue Aug 11, 2022 · 9 comments · Fixed by #1319
Closed

X509 Authentication with OCI registry #491

catric333 opened this issue Aug 11, 2022 · 9 comments · Fixed by #1319
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@catric333
Copy link

I previously opened this issue in helm and was directed to this repo as it is upstream to helm's OCI registry features.

However, I wasn't able to find a related issue here. Would anyone be able to point me in the right direction or link me to the updates to ORAS facilitating x509 mTLS authentication?

@qweeah
Copy link
Contributor

qweeah commented Aug 15, 2022

Looks like HELM 3.8.0 is still using oras-go v1. This should goes to v1 branch of oras-project/oras-go.

@shizhMSFT @Wwwsylvia Does oras-go v2 support mTLS auth?

@shizhMSFT
Copy link
Contributor

oras-go v2 supports mTLS natively.

@TerryHowe
Copy link
Member

If this is don in v2, should this ticket be closed? Sounds like helm needs to upgrade

@TerryHowe
Copy link
Member

helm is on oras.land/oras-go v1.2.2 it appears, on their default branch

@djmcgreal-cc
Copy link

What about the CLI though? I don't see options there.

@TerryHowe
Copy link
Member

What about the CLI though? I don't see options there.

Depending on what command you are using, there should be a --ca-file or a from/to version of that option. There is also a --insecure option. What were you looking for?

@djmcgreal-cc
Copy link

What were you looking for?

The m in mTLS is mutual. --ca-file gives the client a way of trusting a bespoke certificate on the server, but there don't seem to be any arguments where the client can provide a certificate and key for the server to authenticate the client. This is what the linked to issue in helm is also asking. It's about authentication, not trust.

Is this supported in oras-go v2 or is it limited to certificate authority trust?

@shizhMSFT
Copy link
Contributor

This feature request is to let oras support client cert for mTLS.

@shizhMSFT shizhMSFT added the enhancement New feature or request label Mar 22, 2023
@shizhMSFT
Copy link
Contributor

Related implementation: helm/helm#11711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

8 participants