Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add reference details to errors #628

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

sajayantony
Copy link
Contributor

@sajayantony sajayantony commented Oct 25, 2023

Include values of the artifact and or related context in the errors -

This is related to oras-project/oras#1152. See the oras-project/oras#1152 to see the updates to output of errors.

Signed-off-by: Sajay Antony <sajaya@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #628 (bae055f) into main (bdea1ff) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #628   +/-   ##
=======================================
  Coverage   75.12%   75.12%           
=======================================
  Files          59       59           
  Lines        5427     5427           
=======================================
  Hits         4077     4077           
  Misses        995      995           
  Partials      355      355           
Files Coverage Δ
registry/reference.go 68.42% <100.00%> (ø)

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title Add reference details to errors chore: add reference details to errors Oct 26, 2023
@shizhMSFT shizhMSFT merged commit 062ed0e into oras-project:main Oct 26, 2023
7 checks passed
@Wwwsylvia Wwwsylvia mentioned this pull request Jan 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants