Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade image-spec to v1.1.0-rc.3 #496

Merged
merged 2 commits into from
May 4, 2023

Conversation

shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT commented May 4, 2023

This PR fixes and only fixes the compiling errors due to the breaking changes introduced by image-spec v1.1.0-rc.3 where the artifact manifest related specs are removed.

Fix #495.
Fix partially #494

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT shizhMSFT added the dependencies Pull requests that update a dependency file label May 4, 2023
@shizhMSFT shizhMSFT added this to the v2.1.0 milestone May 4, 2023
@shizhMSFT shizhMSFT requested a review from TerryHowe May 4, 2023 08:17
@shizhMSFT shizhMSFT requested a review from sabre1041 May 4, 2023 08:25
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #496 (6a16f2e) into main (264f5f2) will increase coverage by 0.22%.
The diff coverage is 85.71%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
+ Coverage   72.92%   73.14%   +0.22%     
==========================================
  Files          49       49              
  Lines        4528     4528              
==========================================
+ Hits         3302     3312      +10     
+ Misses        919      911       -8     
+ Partials      307      305       -2     
Impacted Files Coverage Δ
content/graph.go 0.00% <0.00%> (ø)
registry/remote/manifest.go 92.85% <ø> (ø)
extendedcopy.go 72.72% <100.00%> (ø)
pack.go 81.63% <100.00%> (ø)
registry/remote/referrers.go 92.04% <100.00%> (ø)
registry/remote/repository.go 68.87% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 8aed964 into oras-project:main May 4, 2023
@shizhMSFT shizhMSFT deleted the fix-oci-spec branch May 4, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Development

Successfully merging this pull request may close these issues.

MediaTypeArtifactManifest not found in v2
6 participants