Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add exported function to get the path of a DynamicStore's underlying config file #676

Closed
qweeah opened this issue Jan 11, 2024 · 0 comments · Fixed by #674
Closed

add exported function to get the path of a DynamicStore's underlying config file #676

qweeah opened this issue Jan 11, 2024 · 0 comments · Fixed by #674
Assignees
@qweeah
Labels
enhancement New feature or request
Milestone
v2.4.0

Comments

@qweeah
Copy link
Contributor

qweeah commented Jan 11, 2024

DynamicStore dynamically determines which store to use based on the settings in a config file. Currently there is no way to get the config file path from caller side.

Suggest adding a function to obtain the path, which will be helpful for ORAS CLI implementation of oras-project/oras#1236.
@qweeah qweeah changed the title add function to return config file path of a DynamicStore add exported function to get the path of a DynamicStore's underlying config file Jan 11, 2024
@qweeah qweeah mentioned this issue Jan 11, 2024
Merged
@yizha1 yizha1 added this to the v2.4.0 milestone Jan 16, 2024
@yizha1 yizha1 added the enhancement New feature or request label Jan 16, 2024
Wwwsylvia pushed a commit that referenced this issue Jan 17, 2024
@qweeah
feat: error type for not finding basic auth creds and export config p…
d8783fe 
…ath (#674)

Two changes proposed in this PR
1) When failed to fetch credentials for basic auth, return a new error
2) Add a new function to DynamicStore

An example usage of the proposed change: oras-project/oras#1235,
resolves #676

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qweeah qweeah

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging a pull request may close this issue.

feat: error type for not finding basic auth creds and export config path qweeah/oras-go
2 participants
@qweeah @yizha1