Skip to content

Commit c385dfe

Browse files
author
Ace Nassri
authored
functions: shrink example pom sample (GoogleCloudPlatform#2845)
* functions: shrink example pom sample * Use helloWorld POM instead (per original discussion) * Remove example-pom tags from firebase (in favor of helloworld)
1 parent 89c728a commit c385dfe

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

functions/firebase/firestore/pom.xml

-7
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
limitations under the License.
1717
-->
1818

19-
<!-- [START functions_example_pom] -->
2019
<project xmlns="http://maven.apache.org/POM/4.0.0"
2120
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
2221
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
@@ -25,14 +24,12 @@
2524
<groupId>com.example.cloud.functions</groupId>
2625
<artifactId>functions-firebase-firestore</artifactId>
2726

28-
<!-- [END functions_example_pom] -->
2927
<parent>
3028
<groupId>com.google.cloud.samples</groupId>
3129
<artifactId>shared-configuration</artifactId>
3230
<version>1.0.17</version>
3331
</parent>
3432

35-
<!-- [START functions_example_pom] -->
3633
<properties>
3734
<maven.compiler.target>11</maven.compiler.target>
3835
<maven.compiler.source>11</maven.compiler.source>
@@ -53,7 +50,6 @@
5350
<version>1.0.1</version>
5451
<scope>provided</scope>
5552
</dependency>
56-
<!-- [END functions_example_pom] -->
5753

5854
<!-- The following dependencies are only required for testing -->
5955
<dependency>
@@ -75,8 +71,6 @@
7571
<scope>test</scope>
7672
</dependency>
7773
</dependencies>
78-
79-
<!-- [START functions_example_pom] -->
8074

8175
<!-- Disable tests during GCF builds (from parent POM) -->
8276
<!-- You can remove this profile to run tests -->
@@ -158,4 +152,3 @@
158152
</plugins>
159153
</build>
160154
</project>
161-
<!-- [END functions_example_pom] -->

functions/helloworld/helloworld/pom.xml

+10
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,27 @@
1616
limitations under the License.
1717
-->
1818

19+
<!-- [START functions_example_pom] -->
1920
<project xmlns="http://maven.apache.org/POM/4.0.0"
2021
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
2122
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
2223
<modelVersion>4.0.0</modelVersion>
2324

2425
<groupId>com.example.cloud.functions</groupId>
2526
<artifactId>functions-hello-world</artifactId>
27+
<!-- [END functions_example_pom] -->
2628

2729
<parent>
2830
<groupId>com.google.cloud.samples</groupId>
2931
<artifactId>shared-configuration</artifactId>
3032
<version>1.0.17</version>
3133
</parent>
3234

35+
<!-- [START functions_example_pom] -->
3336
<properties>
37+
<!-- [END functions_example_pom] -->
3438
<powermock.version>2.0.7</powermock.version>
39+
<!-- [START functions_example_pom] -->
3540
<maven.compiler.target>11</maven.compiler.target>
3641
<maven.compiler.source>11</maven.compiler.source>
3742
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
@@ -45,6 +50,7 @@
4550
<version>1.0.1</version>
4651
<scope>provided</scope>
4752
</dependency>
53+
<!-- [END functions_example_pom] -->
4854

4955
<!-- The following dependencies are only required for testing -->
5056
<dependency>
@@ -97,6 +103,7 @@
97103
</profile>
98104
</profiles>
99105

106+
<!-- [START functions_example_pom] -->
100107
<build>
101108
<plugins>
102109
<plugin>
@@ -116,6 +123,7 @@
116123
<functionTarget>functions.HelloWorld</functionTarget>
117124
</configuration>
118125
</plugin>
126+
<!-- [END functions_example_pom] -->
119127
<plugin>
120128
<groupId>org.apache.maven.plugins</groupId>
121129
<artifactId>maven-surefire-plugin</artifactId>
@@ -131,6 +139,8 @@
131139
<trimStackTrace>false</trimStackTrace>
132140
</configuration>
133141
</plugin>
142+
<!-- [START functions_example_pom] -->
134143
</plugins>
135144
</build>
136145
</project>
146+
<!-- [END functions_example_pom] -->

0 commit comments

Comments
 (0)