Skip to content

Remove feature gate for auxiliary images and prepare for Operator 3.3.0 #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 20, 2021

Conversation

rjeberhard
Copy link
Member

  • Removed the feature gate so that auxiliary images are enabled by default.
  • Update documentation and release notes for Operator 3.3.0.

Note: I took a guess that we would be ready by Friday as we have a couple of pending bug fixes that may make it in.
Note 2: Before we commit this, I'll copy the documentation/staging directory to documentation/3.3.

Copy link
Member

@rosemarymarano rosemarymarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits

@@ -16,6 +16,7 @@ The specification of the operation of the WebLogic domain. Required.
| --- | --- | --- |
| `adminServer` | [Admin Server](#admin-server) | Lifecycle options for the Administration Server, including Java options, environment variables, additional Pod content, and which channels or network access points should be exposed using a NodePort Service. |
| `allowReplicasBelowMinDynClusterSize` | Boolean | Whether to allow the number of running cluster member Managed Server instances to drop below the minimum dynamic cluster size configured in the WebLogic domain configuration, if this is not specified for a specific cluster under the `clusters` field. Defaults to true. |
| `auxiliaryImageVolumes` | array of [Auxiliary Image Volume](#auxiliary-image-volume) | Configure auxiliary image volumes including their respective mount paths. Auxiliary image volumes are in turn referenced by one or more `serverPod.auxiliaryImages` mounts, and are internally implemented using a Kubernetes `emptyDir` volume. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array -> Array

@@ -127,6 +137,7 @@ The current status of the operation of the WebLogic domain. Updated automaticall
| --- | --- | --- |
| `affinity` | [Affinity](k8s1.13.5.md#affinity) | If specified, the Pod's scheduling constraints. See `kubectl explain pods.spec.affinity` |
| `annotations` | Map | The annotations to be added to generated resources. |
| `auxiliaryImages` | array of [Auxiliary Image](#auxiliary-image) | Use an auxiliary image to automatically include directory content from additional images. This is a useful alternative for including Model in Image model files, or other types of files, in a pod without requiring modifications to the pod's base image 'domain.spec.image'. This feature internally uses a Kubernetes emptyDir volume and Kubernetes init containers to share the files from the additional images with the pod. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array -> Array


| Name | Type | Description |
| --- | --- | --- |
| `command` | string | The command for this init container. Defaults to `cp -R $AUXILIARY_IMAGE_PATH/* $TARGET_MOUNT_PATH`. This is an advanced setting for customizing the container command for copying files from the container image to the auxiliary image emptyDir volume. Use the `$AUXILIARY_IMAGE_PATH` environment variable to reference the value configured in `spec.auxiliaryImageVolumes.mountPath`, which defaults to "/auxiliary". Use '$TARGET_MOUNT_PATH' to refer to the temporary directory created by the Operator that resolves to the auxiliary image's internal emptyDir volume. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operator -> operator

| Name | Type | Description |
| --- | --- | --- |
| `command` | string | The command for this init container. Defaults to `cp -R $AUXILIARY_IMAGE_PATH/* $TARGET_MOUNT_PATH`. This is an advanced setting for customizing the container command for copying files from the container image to the auxiliary image emptyDir volume. Use the `$AUXILIARY_IMAGE_PATH` environment variable to reference the value configured in `spec.auxiliaryImageVolumes.mountPath`, which defaults to "/auxiliary". Use '$TARGET_MOUNT_PATH' to refer to the temporary directory created by the Operator that resolves to the auxiliary image's internal emptyDir volume. |
| `image` | string | The name of an image with files located in directory specified by `spec.auxiliaryImageVolumes.mountPath` of the auxiliary image volume referenced by `serverPod.auxiliaryImages.volume`, which defaults to "/auxiliary". |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in directory -> in the directory

@@ -30,7 +30,7 @@ using the operator to deploy and run a WebLogic domain container-packaged web ap
***
#### Current production release

The [current release of the operator](https://github.com/oracle/weblogic-kubernetes-operator/releases) is 3.2.5.
The [current release of the operator](https://github.com/oracle/weblogic-kubernetes-operator/releases) is 3.3.0.
This release was published on June 21, 2021. See the [operator prerequisites]({{< relref "/userguide/prerequisites/introduction.md" >}}) and [supported environments]({{< relref "/userguide/platforms/environments.md" >}}).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This release was published on June 21, 2021 -> This release was published on July 16, 2021.


* [Auxiliary images support](https://oracle.github.io/weblogic-kubernetes-operator/userguide/managing-domains/model-in-image/auxiliary-images/).
* Resolved an issue related to Event creation failure with the error: "StorageError: invalid object, Code: 4" ([#2443](https://github.com/oracle/weblogic-kubernetes-operator/pull/2443)).
* Improve the ability of the operator to use an existing introspection ([#2430](https://github.com/oracle/weblogic-kubernetes-operator/pull/2430)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve -> Improved

@rjeberhard rjeberhard marked this pull request as ready for review July 20, 2021 14:51
Copy link
Member

@ankedia ankedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjeberhard rjeberhard merged commit 6d5b2dd into main Jul 20, 2021
@rjeberhard rjeberhard deleted the remove-ai-featuregate branch January 31, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants