Skip to content

Operator version 3.0.2 #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 57 commits into from
Sep 16, 2020
Merged

Operator version 3.0.2 #1912

merged 57 commits into from
Sep 16, 2020

Conversation

rjeberhard
Copy link
Member

@rjeberhard rjeberhard commented Sep 11, 2020

rjeberhard and others added 30 commits September 9, 2020 19:00
…tor .out, and document log rotation for WLS .out and .log.
…Exceeded (which happens when intro job times out due to DeadlineExceeded).
@rjeberhard rjeberhard marked this pull request as ready for review September 16, 2020 12:21
@rjeberhard
Copy link
Member Author

Copy link
Member

@rosemarymarano rosemarymarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the doc perspective, LGTM.

@russgold
Copy link
Member

What is the process of adding bug fixes? It doesn't look as though you are cherry-picking commits merged into develop, as you've been squashing the PRs to single commits, and here you seem to be using the original commits on the branch. How will this affect merging future work from develop into master?

@rjeberhard
Copy link
Member Author

I cherry-picked the commits from the original PR's.

@rjeberhard
Copy link
Member Author

After we merge to master, I'll merge master back into develop to make sure that there are no conflicts (there shouldn't be).

@russgold
Copy link
Member

What is the advantage of doing that vs. cherry-picking the squashed commits?

| --- | --- | --- | --- |
| September 15, 2020 | v3.0.2 | no | This release contains several fixes, including improvements to log rotation and a fix that avoids unnecessarily updating the domain status. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we list the fixes that went into 3.0.2 for user reference?

Copy link
Member

@rosemarymarano rosemarymarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One edit request/comment.

@@ -4,7 +4,7 @@ date: 2019-03-15T11:25:28-04:00
draft: false
---

### Recent changes
### Releases

| Date | Version | Introduces backward incompatibilities? | Changes |
Copy link
Member

@rosemarymarano rosemarymarano Sep 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes -> Change (I let this go before but it was a mistake. It should be singular, Change, just like all the other headings are singular, Date, Version, Issue, and Description. The question mark after Introduces backward incompatibilities? is ok.) I looked at the Change log in the Hugo UI and it all looks fine, definitely good to go.

@rjeberhard rjeberhard merged commit c4044bb into master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants