Changes to address PR review comments.

Author: ankedia

docs/domains/Domain.json

@@ -118,7 +118,7 @@
           "$ref": "#/definitions/KubernetesResource"
         },
         "maxConcurrentShutdown": {
-          "description": "The maximum WebLogic Server instances that will shutdown in parallel for this cluster when it is being partially shutdown by lowering its replica count.A value of 0 means there is no limit. Defaults to `spec.maxClusterConcurrentShutdown` (which in turn defaults to 1).",
+          "description": "The maximum number of WebLogic Server instances that will shut down in parallel for this cluster when it is being partially shut down by lowering its replica count. A value of 0 means there is no limit. Defaults to `spec.maxClusterConcurrentShutdown`, which defaults to 1.",
           "type": "number",
           "minimum": 0
         },
@@ -360,7 +360,7 @@
           "minimum": 0
         },
         "maxClusterConcurrentShutdown": {
-          "description": "The default maximum WebLogic Server instances that a cluster will shutdown in parallel when it is being partially shutdown by lowering its replica count. You can override this default on a per cluster basis by setting the cluster\u0027s `maxConcurrentShutdown` attribute. A value of 0 means there is no limit. Defaults to 1",
+          "description": "The default maximum number of WebLogic Server instances that a cluster will shut down in parallel when it is being partially shut down by lowering its replica count. You can override this default on a per cluster basis by setting the cluster\u0027s `maxConcurrentShutdown` field. A value of 0 means there is no limit. Defaults to 1.",
           "type": "number",
           "minimum": 0
         },
@@ -841,4 +841,4 @@
     "metadata",
     "spec"
   ]
-}
+}

docs/domains/Domain.md

@@ -34,7 +34,7 @@ The specification of the operation of the WebLogic domain. Required.
 | `logHome` | string | The directory in a server's container in which to store the domain, Node Manager, server logs, server *.out, introspector .out, and optionally HTTP access log files if `httpAccessLogInLogHome` is true. Ignored if `logHomeEnabled` is false. |
 | `logHomeEnabled` | Boolean | Specifies whether the log home folder is enabled. Defaults to true if `domainHomeSourceType` is PersistentVolume; false, otherwise. |
 | `managedServers` | array of [Managed Server](#managed-server) | Lifecycle options for individual Managed Servers, including Java options, environment variables, additional Pod content, and the ability to explicitly start, stop, or restart a named server instance. The `serverName` field of each entry must match a Managed Server that already exists in the WebLogic domain configuration or that matches a dynamic cluster member based on the server template. |
-| `maxClusterConcurrentShutdown` | number | The default maximum WebLogic Server instances that a cluster will shutdown in parallel when it is being partially shutdown by lowering its replica count. You can override this default on a per cluster basis by setting the cluster's `maxConcurrentShutdown` attribute. A value of 0 means there is no limit. Defaults to 1 |
+| `maxClusterConcurrentShutdown` | number | The default maximum number of WebLogic Server instances that a cluster will shut down in parallel when it is being partially shut down by lowering its replica count. You can override this default on a per cluster basis by setting the cluster's `maxConcurrentShutdown` field. A value of 0 means there is no limit. Defaults to 1. |
 | `maxClusterConcurrentStartup` | number | The maximum number of cluster member Managed Server instances that the operator will start in parallel for a given cluster, if `maxConcurrentStartup` is not specified for a specific cluster under the `clusters` field. A value of 0 means there is no configured limit. Defaults to 0. |
 | `replicas` | number | The default number of cluster member Managed Server instances to start for each WebLogic cluster in the domain configuration, unless `replicas` is specified for that cluster under the `clusters` field. For each cluster, the operator will sort cluster member Managed Server names from the WebLogic domain configuration by normalizing any numbers in the Managed Server name and then sorting alphabetically. This is done so that server names such as "managed-server10" come after "managed-server9". The operator will then start Managed Servers from the sorted list, up to the `replicas` count, unless specific Managed Servers are specified as starting in their entry under the `managedServers` field. In that case, the specified Managed Servers will be started and then additional cluster members will be started, up to the `replicas` count, by finding further cluster members in the sorted list that are not already started. If cluster members are started because of their entries under `managedServers`, then a cluster may have more cluster members running than its `replicas` count. Defaults to 0. |
 | `restartVersion` | string | Changes to this field cause the operator to restart WebLogic Server instances. More info: https://oracle.github.io/weblogic-kubernetes-operator/userguide/managing-domains/domain-lifecycle/startup/#restarting-servers. |
@@ -76,7 +76,7 @@ The current status of the operation of the WebLogic domain. Updated automaticall
 | `allowReplicasBelowMinDynClusterSize` | Boolean | Specifies whether the number of running cluster members is allowed to drop below the minimum dynamic cluster size configured in the WebLogic domain configuration. Otherwise, the operator will ensure that the number of running cluster members is not less than the minimum dynamic cluster setting. This setting applies to dynamic clusters only. Defaults to true. |
 | `clusterName` | string | The name of the cluster. This value must match the name of a WebLogic cluster already defined in the WebLogic domain configuration. Required. |
 | `clusterService` | [Kubernetes Resource](#kubernetes-resource) | Customization affecting Kubernetes Service generated for this WebLogic cluster. |
-| `maxConcurrentShutdown` | number | The maximum WebLogic Server instances that will shutdown in parallel for this cluster when it is being partially shutdown by lowering its replica count.A value of 0 means there is no limit. Defaults to `spec.maxClusterConcurrentShutdown` (which in turn defaults to 1). |
+| `maxConcurrentShutdown` | number | The maximum number of WebLogic Server instances that will shut down in parallel for this cluster when it is being partially shut down by lowering its replica count. A value of 0 means there is no limit. Defaults to `spec.maxClusterConcurrentShutdown`, which defaults to 1. |
 | `maxConcurrentStartup` | number | The maximum number of Managed Servers instances that the operator will start in parallel for this cluster in response to a change in the `replicas` count. If more Managed Server instances must be started, the operator will wait until a Managed Server Pod is in the `Ready` state before starting the next Managed Server instance. A value of 0 means all Managed Server instances will start in parallel. Defaults to 0. |
 | `maxUnavailable` | number | The maximum number of cluster members that can be temporarily unavailable. Defaults to 1. |
 | `replicas` | number | The number of cluster member Managed Server instances to start for this WebLogic cluster. The operator will sort cluster member Managed Server names from the WebLogic domain configuration by normalizing any numbers in the Managed Server name and then sorting alphabetically. This is done so that server names such as "managed-server10" come after "managed-server9". The operator will then start Managed Server instances from the sorted list, up to the `replicas` count, unless specific Managed Servers are specified as starting in their entry under the `managedServers` field. In that case, the specified Managed Server instances will be started and then additional cluster members will be started, up to the `replicas` count, by finding further cluster members in the sorted list that are not already started. If cluster members are started because of their related entries under `managedServers`, then this cluster may have more cluster members running than its `replicas` count. Defaults to 0. |
@@ -253,4 +253,4 @@ The current status of the operation of the WebLogic domain. Updated automaticall
 | --- | --- | --- |
 | `health` | string | Server health of this WebLogic Server instance. |
 | `subsystemName` | string | Name of subsystem providing symptom information. |
-| `symptoms` | array of string | Symptoms provided by the reporting subsystem. |
+| `symptoms` | array of string | Symptoms provided by the reporting subsystem. |

operator/src/main/java/oracle/kubernetes/weblogic/domain/model/Cluster.java

@@ -89,10 +89,10 @@ public class Cluster extends BaseConfiguration implements Comparable<Cluster> {
   private Integer maxConcurrentStartup;
 
   @Description(
-          "The maximum WebLogic Server instances that will shutdown in parallel "
-                  + "for this cluster when it is being partially shutdown by lowering its replica count."
-                  + "A value of 0 means there is no limit. Defaults to `spec.maxClusterConcurrentShutdown` "
-                  + "(which in turn defaults to 1)."
+          "The maximum number of WebLogic Server instances that will shut down in parallel "
+                  + "for this cluster when it is being partially shut down by lowering its replica count. "
+                  + "A value of 0 means there is no limit. Defaults to `spec.maxClusterConcurrentShutdown`, "
+                  + "which defaults to 1."
   )
   @Range(minimum = 0)
   private Integer maxConcurrentShutdown;
@@ -217,6 +217,8 @@ public String toString() {
         .append("clusterService", clusterService)
         .append("maxUnavailable", maxUnavailable)
         .append("allowReplicasBelowMinDynClusterSize", allowReplicasBelowMinDynClusterSize)
+        .append("maxConcurrentStartup", maxConcurrentStartup)
+        .append("maxConcurrentShutdown", maxConcurrentShutdown)
         .toString();
   }
 

operator/src/main/java/oracle/kubernetes/weblogic/domain/model/DomainSpec.java

@@ -210,10 +210,10 @@ public class DomainSpec extends BaseConfiguration {
   private Integer maxClusterConcurrentStartup;
 
   @Description(
-          "The default maximum WebLogic Server instances that a cluster will shutdown in parallel when it is being "
-                  + "partially shutdown by lowering its replica count. You can override this default on a per cluster "
-                  + "basis by setting the cluster's `maxConcurrentShutdown` attribute. A value of 0 means there is "
-                  + "no limit. Defaults to 1"
+          "The default maximum number of WebLogic Server instances that a cluster will shut down in parallel when it "
+                  + "is being partially shut down by lowering its replica count. You can override this default on a per "
+                  + "cluster basis by setting the cluster's `maxConcurrentShutdown` field. A value of 0 means "
+                  + "there is no limit. Defaults to 1."
   )
   @Range(minimum = 0)
   private Integer maxClusterConcurrentShutdown;
@@ -831,7 +831,9 @@ public String toString() {
             .append("logHomeEnabled", logHomeEnabled)
             .append("includeServerOutInPodLog", includeServerOutInPodLog)
             .append("configOverrides", configOverrides)
-            .append("configOverrideSecrets", configOverrideSecrets);
+            .append("configOverrideSecrets", configOverrideSecrets)
+            .append("maxClusterConcurrentStartup",maxClusterConcurrentStartup)
+            .append("maxClusterConcurrentShutdown",maxClusterConcurrentShutdown);
 
     return builder.toString();
   }