First code changes based on code review

Author: lennyphan

integration-tests/src/test/java/oracle/weblogic/domain/Istio.java

@@ -18,11 +18,11 @@ public class Istio {
   @ApiModelProperty("The WebLogic readiness port for Istio. Defaults to 8888. Not required.")
   private Integer readinessPort;
 
-  public static Integer DEFAULT_REPLICATION_PORT = 4358;
+  public static Integer DEFAULT_REPLICATION_PORT = 4564;
 
   @ApiModelProperty("The operator will create a WebLogic network access point with this port that will then be exposed "
       + "from the container running the WebLogic Server instance. The WebLogic Replication Service will use this "
-      + "network access point for all replication traffic. Defaults to 4358.")
+      + "network access point for all replication traffic. Defaults to 4564.")
   private Integer replicationChannelPort = DEFAULT_REPLICATION_PORT;
 
   @ApiModelProperty("Starting with Istio 1.10, the networking behavior was changed in that the proxy no "

operator/src/main/java/oracle/kubernetes/operator/helpers/JobHelper.java

@@ -45,6 +45,7 @@
 import oracle.kubernetes.weblogic.domain.model.DomainSpec;
 import oracle.kubernetes.weblogic.domain.model.DomainStatus;
 import oracle.kubernetes.weblogic.domain.model.IntrospectorJobEnvVars;
+import oracle.kubernetes.weblogic.domain.model.Istio;
 import oracle.kubernetes.weblogic.domain.model.Server;
 import oracle.kubernetes.weblogic.domain.model.ServerEnvVars;
 import org.jetbrains.annotations.Nullable;
@@ -335,8 +336,17 @@ List<V1EnvVar> getConfiguredEnvVars(TuningParameters tuningParameters) {
       addEnvVar(vars, IntrospectorJobEnvVars.ISTIO_READINESS_PORT, Integer.toString(getIstioReadinessPort()));
       addEnvVar(vars, IntrospectorJobEnvVars.ISTIO_POD_NAMESPACE, getNamespace());
       if (isIstioEnabled()) {
-        addEnvVar(vars, IntrospectorJobEnvVars.ISTIO_VERSION, getIstioVersion());
-        addEnvVar(vars, IntrospectorJobEnvVars.ISTIO_REPLICATION_PORT, Integer.toString(getIstioReplicationPort()));
+        // Only add the following Istio configuration environment variables when explicitly configured
+        // otherwise the introspection job will needlessly run, after operator upgrade, based on generated
+        // hash code of the set of environment variables.
+        String istioVersion = getIstioVersion();
+        if (istioVersion != null && !istioVersion.isEmpty()) {
+          addEnvVar(vars, IntrospectorJobEnvVars.ISTIO_VERSION, getIstioVersion());
+        }
+
+        if (getIstioReplicationPort() != Istio.DEFAULT_REPLICATION_PORT) {
+          addEnvVar(vars, IntrospectorJobEnvVars.ISTIO_REPLICATION_PORT, Integer.toString(getIstioReplicationPort()));
+        }
       }
       if (isUseOnlineUpdate()) {
         addEnvVar(vars, IntrospectorJobEnvVars.MII_USE_ONLINE_UPDATE, "true");

operator/src/main/java/oracle/kubernetes/weblogic/domain/model/IntrospectorJobEnvVars.java

@@ -159,7 +159,7 @@ static boolean isReserved(String name) {
   private static final List<String> RESERVED_NAMES = Arrays.asList(
       NAMESPACE, INTROSPECT_HOME, CREDENTIALS_SECRET_NAME, OPSS_KEY_SECRET_NAME, OPSS_WALLETFILE_SECRET_NAME,
       RUNTIME_ENCRYPTION_SECRET_NAME, WDT_DOMAIN_TYPE, DOMAIN_SOURCE_TYPE, ISTIO_ENABLED, ISTIO_READINESS_PORT,
-      ISTIO_REPLICATION_PORT, ISTIO_VERSION, ISTIO_POD_NAMESPACE, WDT_MODEL_HOME, MII_USE_ONLINE_UPDATE,
+      ISTIO_POD_NAMESPACE, WDT_MODEL_HOME, MII_USE_ONLINE_UPDATE,
       MII_COMMIT_AND_ROLL, MII_COMMIT_ONLY, MII_WDT_CONNECT_TIMEOUT, MII_WDT_ACTIVATE_TIMEOUT, MII_WDT_DEPLOY_TIMEOUT,
       MII_WDT_REDEPLOY_TIMEOUT, MII_WDT_UNDEPLOY_TIMEOUT, MII_WDT_START_APPLICATION_TIMEOUT,
       MII_WDT_STOP_APPLICAITON_TIMEOUT, MII_WDT_SET_SERVERGROUPS_TIMEOUT,