Skip to content

Commit 46b91d5

Browse files
Fix typing issues with setters for oracledb.defaults.fetch_lobs and
oracledb.defaults.fetch_decimals (#458).
1 parent 8986c09 commit 46b91d5

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

doc/src/release_notes.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,9 @@ Common Changes
154154
:meth:`oracledb.connect_async()`, :meth:`oracledb.create_pool()` and
155155
:meth:`oracledb.create_pool_async()`
156156
(`issue 438 <https://github.com/oracle/python-oracledb/issues/438>`__).
157+
#) Fix typing issues with setters for :attr:`defaults.fetch_lobs` and
158+
:attr:`defaults.fetch_decimals`
159+
(`issue 458 <https://github.com/oracle/python-oracledb/issues/458>`__).
157160
#) Error ``DPY-2053: python-oracledb thin mode cannot be used because thick
158161
mode has already been enabled`` is now raised when attempting to use
159162
asyncio in thick mode

src/oracledb/defaults.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def fetch_lobs(self) -> bool:
7575
return self._impl.fetch_lobs
7676

7777
@fetch_lobs.setter
78-
def fetch_lobs(self, value: str):
78+
def fetch_lobs(self, value: bool):
7979
self._impl.fetch_lobs = value
8080

8181
@property
@@ -87,7 +87,7 @@ def fetch_decimals(self) -> bool:
8787
return self._impl.fetch_decimals
8888

8989
@fetch_decimals.setter
90-
def fetch_decimals(self, value: str):
90+
def fetch_decimals(self, value: bool):
9191
self._impl.fetch_decimals = value
9292

9393
@property

0 commit comments

Comments
 (0)