Skip to content

Commit 3db2ee9

Browse files
If ping fails, the request should not be marked as completed!
1 parent 41693a2 commit 3db2ee9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/oracledb/impl/thin/pool.pyx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,10 +224,10 @@ cdef class BaseThinPoolImpl(BasePoolImpl):
224224
list depending on whether the waiter is still waiting for the request
225225
to be satisfied!
226226
"""
227-
request.completed = True
228227
request.in_progress = False
229228
request.bg_processing = False
230229
if request.conn_impl is not None:
230+
request.completed = True
231231
if not request.is_replacing and not request.requires_ping:
232232
self._open_count += 1
233233
if self._num_to_create > 0:

0 commit comments

Comments
 (0)