Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and Test Oracle R2DBC with a Github Action #2

Merged
merged 19 commits into from
Jun 21, 2021

Conversation

Michael-A-McMahon
Copy link
Member

(Please don't merge yet: I'm using this pull request just to trigger the action and verify if it works)
I'm planning to add another action that executes our tests as well.

@jeandelavarene jeandelavarene changed the base branch from development to main March 12, 2021 16:43
@Michael-A-McMahon
Copy link
Member Author

In the last test run, looks like the action hung on OracleBatchImplTest. Most likely that's due to Issue #5, where concurrent SQL execution and row processing leads to a blocked thread. I'd figure the Github runner is a single core virtual environment, which means ForkJoinPool.commonPool() has just one thread. When you've got a pool of just one thread, and that thread is blocked, you're not going to make progress any time soon.
Once #15 is approved and merged into main, we can give this test action another shot.

@Michael-A-McMahon Michael-A-McMahon changed the title [WIP] Build and Test Oracle R2DBC with a Github Action Build and Test Oracle R2DBC with a Github Action Jun 14, 2021
@Michael-A-McMahon Michael-A-McMahon marked this pull request as ready for review June 14, 2021 00:17
@Michael-A-McMahon
Copy link
Member Author

This pull request is now (finally) ready for review and, if approved, it may be merged into the main branch. With this action in our repo, an automated test run will begin whenever there is a pull request.

After pulling in the latest changes from main, the tests are no longer failing or getting stuck.

@jeandelavarene jeandelavarene merged commit 5fac881 into main Jun 21, 2021
@jeandelavarene jeandelavarene deleted the build-and-test-action branch October 27, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants