definition search displays comment lines (Bugzilla #2573)

[vladak]

status CLOSED severity enhancement in component webapp for ---
Reported in version unspecified on platform ANY/Generic
Assigned to: Trond Norbye

On 2008-07-17 07:43:03 +0000, Vijay wrote:

Definition search in opengrok displays the matching comment lines of the source file also. It should only display definition.
e.g. In case of c/c++ files, it shows the matching lines which are in between /* ....*/.

On 2008-08-01 11:52:51 +0000, Trond Norbye wrote:

This is not a bug, but a feature. OpenGrok will just search for files containing the definition, but it will list all occurrences of the symbol in the files that contain the definition. If you look in the search result it will print "function" behind the mach for the actual definition in the file.

If you dislike this behavior, please reopen the issue and create a patch that removes the other results :-)

[acdevlin]

Personal fix for this on my own branch. Definitions search will ONLY return actual definition statements instead of comments, etc.

acdevlin/OpenGrok@b16a600

Screenshots: http://imgur.com/a/nuwxE#0

Not sure if you want this to be merged in or not, since it fundamentally changes how one search type works...

[kahatlen]

This sounds useful to me. Perhaps even more useful if we added a "show all" link that could show you all the occurrences in the file if you wanted to (could probably be achieved by linking to the existing more.jsp page).

@acdevlin, would you be willing to sign the OCA - http://www.oracle.com/technetwork/goto/oca - so that your code can be incorporated?

Thanks.

[acdevlin]

@kahatlen signed and emailed a copy to oracle-ca_us@oracle.com, will hopefully get approval from them soon!

Also, I like the idea of a "show all" link.

[Hlipa]

I see also function calls. Does fix fix it as well? thx

[tarzanek]

@Hlipa most probably not, they will still be there, it just removes the matches without any tags it seems