-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[GR-37486] Fix reflection metadata-related test failures #4414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4d94f40
to
8f636ab
Compare
Hi @loicottet, although this PR fixes the NPEs that are thrown after #4222 we are still seeing a number of failures (since #4222 merge): Image heap writing found a class not seen during static analysis...
See:
Enclosing method not found
See:
java.lang.reflect.MalformedParameterizedTypeException
See: |
f0cf82f
to
311db26
Compare
@loicottet thank you for working on this. The PR already fixes most of the issues, but there are still some left. I did a test run with your latest push and I see the following issues with Quarkus:
|
311db26
to
9b42de5
Compare
23da0e7
to
1277e8a
Compare
1277e8a
to
283fd6c
Compare
283fd6c
to
9a2700e
Compare
@zakkak With this PR merged, |
Isn't this a step backward? Are those really needed in the image? |
This is a slight step backwards in terms of image size, however this improves Native Image correctness and understandability. The previous criteria for inclusion could lead to configuration-related failures when an annotation got newly referenced anywhere in a project, whereas the current behaviour is completely predictable. Also, the image size impact is reduced since we store annotations in encoded form and only instantiate them when needed. |
No description provided.