[GR-69089] Make CGlobalDataBasePointer layer aware #12216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to the correct layer is used when accessing CGlobalData
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
deleted the
scoppey/GR-69089/make-cglobal-base-pointer-layer-aware
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In layered image, there is one
CGlobalDatamemory space per layer, so oneCGlobalDataBasePointeris also needed for each layer.Only non constant
CGlobalDataneed to use this base address, so the only cases where issues could happen were in runtime compilation and on JNI library loading.This PR ensure that the base pointer corresponding the the
CGlobalDatais accessed.This PR also contains a small fix on
LayeredImageHeapMap, where a layer with an empty map would not be skipped properly.