[GR-69604] Prevent constant folding of elements that should not be reflectively accessible #12190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstant folded in the ReflectionPlugins
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
deleted the
scoppey/GR-69604/prevent-constant-folding-inject-accessors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields annotated with
@InjectAccessorsshould never be in the image heap.However, the
ReflectionPluginscan constant fold calls togetDeclaredField, even if the field is annotated as such.Those fields are already silently not registered for reflection because of
SubstitutionReflectivityFilter#shouldExclude.This PR refactors
SubstitutionReflectivityFilterinto aFeatureand reuses it to ensure allAnnotatedElementsthat should be excluded from the image are not constant folded.