[GR-62562] Skip methods not reachable in current layer from compilation. #11031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR skips methods not reachable in current layer from compilation. When building the base layer there could be methods that were reached and analyzed but not compiled in the base layer, e.g., they were always inlined. These methods can be referenced in the app layer, but not reached during the app layer's analysis, so their base layer graph is never loaded. Such a method can be considered as a potential compilation target when it is the implementation of a method invoked in the app layer. Since we don't have an analysis graph we cannot compile it. As an workaround the method is currently skipped from compilation, however it should not be called at run time since it was not reached during analysis.
This PR also skips deleted fields from relinking.