register an object replacer for ResourceBundles

Author: d-kozak

substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/jdk/localization/LocalizationFeature.java

@@ -71,7 +71,6 @@
 import org.graalvm.compiler.nodes.graphbuilderconf.NodePlugin;
 import org.graalvm.compiler.options.Option;
 import org.graalvm.compiler.options.OptionType;
-import org.graalvm.compiler.serviceprovider.JavaVersionUtil;
 import org.graalvm.nativeimage.ImageSingletons;
 import org.graalvm.nativeimage.Platform;
 import org.graalvm.nativeimage.Platforms;
@@ -168,7 +167,7 @@ public static class Options {
         public static final HostedOptionKey<Boolean> IncludeAllLocales = new HostedOptionKey<>(false);
 
         @Option(help = "Optimize the resource bundle lookup using a simple map.", type = OptionType.User)//
-        public static final HostedOptionKey<Boolean> LocalizationOptimizedMode = new HostedOptionKey<>(JavaVersionUtil.JAVA_SPEC == 8);
+        public static final HostedOptionKey<Boolean> LocalizationOptimizedMode = new HostedOptionKey<>(true);
 
         @Option(help = "Store the resource bundle content more efficiently in the fallback mode.", type = OptionType.User)//
         public static final HostedOptionKey<Boolean> LocalizationSubstituteLoadLookup = new HostedOptionKey<>(true);
@@ -260,6 +259,40 @@ public void afterRegistration(AfterRegistrationAccess access) {
         }
     }
 
+    @Override
+    public void duringSetup(DuringSetupAccess access) {
+        if (optimizedMode) {
+            access.registerObjectReplacer(this::eagerlyInitializeBundles);
+        }
+    }
+
+    /**
+     * In the optimized localization support, the bundles are stored in a map. In order to make the
+     * getContents methods unreachable, the bundles are initialized eagerly and the lookup methods
+     * are substituted. However, if there are bundle instances somewhere in the heap that were not
+     * put in the map, they won't be initialized and therefore accessing their content will cause
+     * runtime failures. Therefore, we visit each object in the heap and if it is a ResourceBundle,
+     * we eagerly initialize it.
+     */
+    private Object eagerlyInitializeBundles(Object object) {
+        assert optimizedMode : "Should only be triggered in the optimized mode.";
+        if (object instanceof ResourceBundle) {
+            ResourceBundle bundle = (ResourceBundle) object;
+            try {
+                /*
+                 * getKeys can be null for ResourceBundle.NONEXISTENT_BUNDLE, which causes the
+                 * keySet method to crash.
+                 */
+                if (bundle.getKeys() != null) {
+                    bundle.keySet();
+                }
+            } catch (Exception ex) {
+                trace("Failed to eagerly initialize bundle " + bundle + ", " + bundle.getBaseBundleName() + ", reason " + ex.getClass() + " " + ex.getMessage());
+            }
+        }
+        return object;
+    }
+
     @Platforms(Platform.HOSTED_ONLY.class)
     private LocalizationSupport selectLocalizationSupport() {
         if (optimizedMode) {