Add 12213 Docker image sample for Apache with WebLogic 12.2.1.3.0 Proxy Plugin #849

doxiao · 2018-04-18T17:53:59Z

This includes a Docker Image that

is based from https:2.4 image
adds WebLogic 12.2.1.3.0 proxy plugin
adds a sample plugin config that can handle a simple WebLogic domain that contains a admin server and a cluster.

See README for steps to test the image.

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

mriccell

I have completed my initial review. Please see comments.

mriccell · 2018-04-18T18:06:19Z

OracleWebLogic/samples/12213-webtier-apache/Dockerfile

+#
+# REQUIRED FILES TO BUILD THIS IMAGE
+# ----------------------------------
+# fmw_12.2.1.3.0_wls_Disk1_1of1.zip 


The requirement is the Webtier installer fmw_12.2.1.3.0_wlsplugins_Disk1_1of1.zip

mriccell · 2018-04-18T18:07:34Z

OracleWebLogic/samples/12213-webtier-apache/Dockerfile

+# REQUIRED FILES TO BUILD THIS IMAGE
+# ----------------------------------
+# fmw_12.2.1.3.0_wls_Disk1_1of1.zip 
+# Download the Generic installer from http://www.oracle.com/technetwork/middleware/weblogic/downloads/wls-for-dev-1703574.html and save it in this same folder.


The URL for webtier download is http://www.oracle.com/technetwork/middleware/webtier/downloads/index-jsp-156711.html

mriccell · 2018-04-18T18:17:15Z

OracleWebLogic/samples/12213-webtier-apache/README.md

@@ -0,0 +1,43 @@
+Example of Apache Web Server with WebLogic 12.2.1.3.0 Plugin
+=====
+This sample shows how to run a load balancer for a WebLogic cluster, from inside a container in the same network as the WLS Cluster.


WLS -> WebLogic Server

mriccell · 2018-04-18T18:17:44Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+This sample shows how to run a load balancer for a WebLogic cluster, from inside a container in the same network as the WLS Cluster.
+
+# How to build image
+Download file **Oracle WebLogic Server Proxy Plugins 12.2.1** [fmw_12.2.1.3.0_wlsplugins_Disk1_1of1.zip](http://www.oracle.com/technetwork/middleware/webtier/downloads/index-jsp-156711.html) (see .download file)


Oracle WebLogic Server Proxy Plugins 12.2.1.3

mriccell · 2018-04-18T18:19:59Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+        $ sh build.sh
+
+Oracle developers can use build_internal.sh, which set up HTTP/HTTPS proxies.


If you need to set up HTTP/HTTPS proxies, build the image using script build_internal.sh

mriccell · 2018-04-18T18:34:15Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+## Example
+Start an AdminServer from the **12213-domain** sample by calling:
+
+        $ docker run -d --name wlsadmin -h wlsadmin 12213-domain


Start a container from the WebLogic install image. You can override the default values of the following parameters during runtime with the -e option:
ADMIN_NAME (default: AdminServer)
ADMIN_PORT (default: 7001)
ADMIN_USERNAME (default: weblogic)
ADMIN_PASSWORD (default: Auto Generated)
DOMAIN_NAME (default: base_domain)
DOMAIN_HOME (default: /u01/oracle/user_projects/domains/base_domain)

NOTE To set the DOMAIN_NAME, you must set both DOMAIN_NAME and DOMAIN_HOME.

$ docker run -d -e ADMIN_USERNAME=weblogic -e ADMIN_PASSWORD=welcome1 -e DOMAIN_HOME=/u01/oracle/user_projects/domains/abc_domain -e DOMAIN_NAME=abc_domain store/oracle/weblogic:12.2.1.3

mriccell · 2018-04-18T18:34:39Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+The values of **WEBLOGIC_CLUSTER** must be valid, existing containers running WebLogic servers.
+
+## Example


First make sure you have the WebLogic Server 12.2.1.3 install image, pull the WebLogic install image from the DockerStore store/oracle/weblogic:12.2.1.3, or build your own image oracle/weblogic:12.2.1.3-developer at [https://github.com/oracle/docker-images/tree/master/OracleWebLogic/dockerfiles/12.2.1.3].

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

Djelibeybi · 2018-04-18T23:08:41Z

We cannot merge this as it is based on http:2.4 instead of oraclelinux:7-slim which results in an unsupportable image.

I'm not going to close this pull request, but you need to update it to use oraclelinux:7-slim and just install httpd using yum instead. We provide Apache HTTPd 2.4 with Oracle Linux 7 anyway.

Djelibeybi

The Dockerfile has no ENTRYPOINT or CMD directive, so the image will do nothing when it starts. It'll just exit.

Once you've updated the image to actually use Oracle Linux 7, please also update the Dockerfile so that when you start a container it actually runs httpd.

Djelibeybi · 2018-04-18T23:09:42Z

OracleWebLogic/samples/12213-webtier-apache/Dockerfile

+#
+# Note if needed, pull the latest httpd image and tag it as: httpd:2.4
+#
+FROM httpd:2.4


This has to be changed to FROM oraclelinux:7-slim. You can then run yum -y install httpd inside the container to install Apache HTTPd 2.4.

This image inherits the base image's CMD directive.

Of course, we'll have a CMD if we change to use oraclelinux:7-slim as the base. I'll make the change. Thanks.

Avi

The image we are trying to create is the WebLogic Server Apache HTTP Server Proxy Plugin, we need to extend the Apache HTTP Server Project since we need the scripts and functionality already included in the image. When we do a yum -y install httpd inside the container to install Apache HTTPd 2.4 we do not have the same directory or code. What is the reason we need to base this on OL slim?

mriccell · 2018-04-18T19:37:14Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+        $ sh build_internal.sh
+
+# How to run container
+Run this image by calling:


Run the Apache image by calling:

mriccell · 2018-04-18T19:46:09Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+        $ docker run -d -e WEBLOGIC_CLUSTER=host1:port,host2:port,host3:port --net=<some net> -p 80:80 12213-apache
+
+The values of **WEBLOGIC_CLUSTER** must be valid, existing containers running WebLogic servers.


How to configure for sample 2 where you have a group of single domain (Admin server containers)?

mriccell · 2018-04-18T19:55:06Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+First make sure you have the WebLogic Server 12.2.1.3 install image, pull the WebLogic install image from the DockerStore store/oracle/weblogic:12.2.1.3, or build your own image oracle/weblogic:12.2.1.3-developer at [https://github.com/oracle/docker-images/tree/master/OracleWebLogic/dockerfiles/12.2.1.3].
+
+
+## Example


Admin Server Containers Use Case

mriccell · 2018-04-18T19:56:17Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+Now you can access the WebLogic Admin Console under **http://localhost/console** (default to port 80) instead of using port 7001.
+
+If you are using multihost network, remove --link and set "--net=<your net>".


Remove this sentence does not apply to Admin Server containers

mriccell · 2018-04-18T19:56:59Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+If you are using multihost network, remove --link and set "--net=<your net>".
+
+## Advanced Use Cases


WebLogic Domain/Cluster Use Case

mriccell · 2018-04-18T19:57:17Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+If you are using multihost network, remove --link and set "--net=<your net>".
+
+## Advanced Use Cases
+The Docker image supplies a simple Oracle WebLogic iServer Proxy Plugin configuraiton for Apache.


typo iServer, typo configuraiton

mriccell · 2018-04-18T19:58:28Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+If you want to start the Apache container with some pre-specified mod_weblogic configuration:
+
+* Depending on your weblogic environment , create a custom_mod_wl_apache.conf file by referring to custom_mod_wl_apache.conf.sample and Chapter 3 @ Fusion Middleware Using Oracle WebLogic Server Proxy Plug-Ins documentation.


Add link to documentation [https://docs.oracle.com/middleware/12213/webtier/develop-plugin/apache.htm#GUID-231FB5FD-8D0A-492A-BBFD-DC12A31BF2DE]

mriccell · 2018-04-18T19:59:23Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+* Depending on your weblogic environment , create a custom_mod_wl_apache.conf file by referring to custom_mod_wl_apache.conf.sample and Chapter 3 @ Fusion Middleware Using Oracle WebLogic Server Proxy Plug-Ins documentation.
+
+* Place the custom_mod_wl_apache.conf file in a directory in the host, (for example, "/scratch/DockerVolume/ApacheVolume"),  and then mount this directory into the container at the location "/config". By doing so, the contents of host directory /scratch/DockerVolume/ApacheVolume(and hence custom_mod_wl_apache.conf) will become available in the container at the mount point.


Does this directory require special permissions?

The process inside container will only read the file, and will not update it.

mriccell · 2018-04-18T20:01:27Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+This mounting can be done by using the -v option with the 'docker run' command as shown below. 
+
+        $ docker run -v /scratch/DockerVolume/ApacheVolume:/config -w /config -d -e WEBLOGIC_HOST=<admin-host> -e WEBLOGIC_PORT=7001 -p 80:80 12213-apache
+


Start a WebLogic domain/cluster by following the RADME in sample/12213-domain, [https://github.com/oracle/docker-images/tree/master/OracleWebLogic/samples/12213-domain].

mriccell · 2018-04-18T20:08:33Z

OracleWebLogic/samples/12213-webtier-apache/README.md

@@ -0,0 +1,66 @@
+Example of Apache Web Server with WebLogic 12.2.1.3.0 Plugin
+=====
+This sample shows how to run a load balancer for a WebLogic cluster, from inside a container in the same network as the WebLogic Server cluster.


This sample provides 2 use cases: 1) Load balance requests to a group of single server domain (Admin server containers). 2) Load balance requests to managed servers in a WebLogic cluster, where each managed server is running inside a docker container.

Djelibeybi

Please review all your Markdown formatting as well. There are lots of instances where there are missing back ticks around paths and filenames, for example.

Also, make sure there are no spaces before punctuation like commas and periods.

Djelibeybi · 2018-04-19T16:40:25Z

OracleWebLogic/samples/12213-webtier-apache/build_internal.sh

+#
+# Licensed under the Universal Permissive License v 1.0 as shown at http://oss.oracle.com/licenses/upl.
+#
+docker build --build-arg http_proxy=http://www-proxy.us.oracle.com:80 \


This entire file needs to be removed. You cannot expose internal Oracle hosts publicly.

Djelibeybi · 2018-04-19T16:41:59Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+If you need to set up HTTP/HTTPS proxies, build the image using script build_internal.sh.
+
+        $ sh build_internal.sh


This file MUST be removed. You cannot expose internal Oracle hosts publicly. You must change the build.sh to expose any proxies set in the host shell to build.

This is used in all the buildDockerImage.sh scripts in this repo:

# Proxy settings PROXY_SETTINGS="" if [ "${http_proxy}" != "" ]; then PROXY_SETTINGS="$PROXY_SETTINGS --build-arg http_proxy=${http_proxy}" fi if [ "${https_proxy}" != "" ]; then PROXY_SETTINGS="$PROXY_SETTINGS --build-arg https_proxy=${https_proxy}" fi if [ "${ftp_proxy}" != "" ]; then PROXY_SETTINGS="$PROXY_SETTINGS --build-arg ftp_proxy=${ftp_proxy}" fi if [ "${no_proxy}" != "" ]; then PROXY_SETTINGS="$PROXY_SETTINGS --build-arg no_proxy=${no_proxy}" fi if [ "$PROXY_SETTINGS" != "" ]; then echo "Proxy settings were found and will be used during the build." fi

Djelibeybi · 2018-04-19T16:43:07Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+or
+
+        $ sh build.sh


This should be renamed to buildDockerImage.sh for repo consistency.

Djelibeybi · 2018-04-19T16:43:46Z

OracleWebLogic/samples/12213-webtier-apache/build.sh

+#
+# Licensed under the Universal Permissive License v 1.0 as shown at http://oss.oracle.com/licenses/upl.
+#
+docker build -t 12213-apache .


This is not acceptable as a script. Please review the buildDockerImage.sh scripts used in the repo to provide more flexibility when building this image.

Djelibeybi · 2018-04-19T16:46:19Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+* Depending on your weblogic environment , create a custom_mod_wl_apache.conf file by referring to custom_mod_wl_apache.conf.sample and Chapter 3 @ Fusion Middleware Using Oracle WebLogic Server Proxy Plug-Ins documentation.
+
+* Place the custom_mod_wl_apache.conf file in a directory in the host, (for example, "/scratch/DockerVolume/ApacheVolume"),  and then mount this directory into the container at the location "/config". By doing so, the contents of host directory /scratch/DockerVolume/ApacheVolume(and hence custom_mod_wl_apache.conf) will become available in the container at the mount point.


You should not map the volume. Rather, map the file directly, i.e. -v /scratch/custom_mod_wl_apache.conf:/config/custom_mod_wl_apache.conf in the docker run command.

Djelibeybi · 2018-04-19T16:47:07Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+* Depending on your weblogic environment , create a custom_mod_wl_apache.conf file by referring to custom_mod_wl_apache.conf.sample and Chapter 3 @ Fusion Middleware Using Oracle WebLogic Server Proxy Plug-Ins documentation.
+
+* Place the custom_mod_wl_apache.conf file in a directory in the host, (for example, "/scratch/DockerVolume/ApacheVolume"),  and then mount this directory into the container at the location "/config". By doing so, the contents of host directory /scratch/DockerVolume/ApacheVolume(and hence custom_mod_wl_apache.conf) will become available in the container at the mount point.


Also, you should back ticks around all paths and filenames to format them in a fixed-width font, i.e. custom_mod_wl_apache.conf and /scratch/DockerVolume/ApacheVolume.

mriccell · 2018-04-19T20:48:20Z

Avi

The image we are trying to create is the WebLogic Server Apache HTTP Server Proxy Plugin, we need to extend the Apache HTTP Server Project since we need the scripts and functionality already included in the image. When we do a yum -y install httpd inside the container to install Apache HTTPd 2.4 we do not have the same directory or code. What is the reason we need to base this on OL slim?

Djelibeybi · 2018-04-20T00:08:06Z

@mriccell we cannot merge any images that do not extend an Oracle Linux base image. This is golden rule 1 in the contribution guide: https://github.com/oracle/docker-images/blob/master/CONTRIBUTING.md

(Yes, we have Windows-based Java images. Those are the only exceptions to rule 1).

1) use oraclelinux:7-slim as the base 2) repalce build.sh and build_internal.sh with buildDockerImage.sh 3) updated README.md Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

mriccell

Made a few review comments

mriccell · 2018-04-20T22:39:01Z

OracleWebLogic/samples/12213-webtier-apache/Dockerfile

+COPY custom_mod_wl_apache.conf.sample /config/custom_mod_wl_apache.conf
+COPY container-scripts/* /u01/oracle/container-scripts/
+
+RUN yum install -y unzip && \


You do not need to install a unzip just do $JAVA_HOME/bin/jar xf /u01/$FMW_PKG

I don't know if oraclelinux:7-slim contains a JDK.

I don't think oraclelinux:7-slim contains a JDK. But need confirmation from Avi.

Makes sense then you can do a yum remove after you unzip

Doing a yum remove or erase does not make much difference in the image size

mriccell · 2018-04-20T22:41:45Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+Run an Apache container to access an admin server that is running on <host> and listening to <port>.
+
+        $ docker run -d -e WEBLOGIC_HOST=i<host> WEBLOGIC_PORT=<port> -p 80:80 12213-apache


mriccell · 2018-04-20T22:44:17Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+        $ docker run -d -e WEBLOGIC_CLUSTER=host1:port,host2:port,host3:port --net=<some net> -p 80:80 12213-apache
+
+Run an Apache image to proxy and load balance to a list of managed servers in a cluster


How is the example for load balancing to individual or clustered managed server different. The sample seems exactly the same.

It is just list of servers. for cluster there is an option to use a cluster URL.

I understand the multiple server host:port vs the cluster url. My comment refers to line 25 and line 31 are identical.

mriccell · 2018-04-20T22:47:55Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+### Admin Server Only Example
+
+First make sure you have the WebLogic Server 12.2.1.3 sample and build your own image 12213-domain at [https://github.com/oracle/docker-images/tree/master/OracleWebLogic/samples/12213-domain].


For Admin Server only containers they either must pull the image from the Docker Store 'docker pull store/oracle/weblogic:12.2.1.3' or they can build it them selves from https://github.com/oracle/docker-images/tree/master/OracleWebLogic/dockerfiles/12.2.1.3. The 12213-domain sample is meant to run a domain with a cluster.

We are showing apache part for admin server only. It is okay to use a domain with clusters although we only use admin server in the example. We are going to add cluster examples in the near future.

There are two WebLogic topologies we support in Docker, the single Admin server/domain per container which you get from running a container from the WebLogic install image, and the WebLogic domain/cluster with one admin server and multiple clustered managed servers. Your example for the single Admin server should use the WebLogic install image to run an admin server container, the WLST that is used in that image creates a domain with a single admin server. The 12213-domain WLST scripts that get invoked when you run the Admin server container create a WLS domain with an admin server, cluster with multiple managed servers.

mriccell · 2018-04-20T22:49:05Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+To start a containerized Admin Server, run:
+
+        $ docker run -d --name wlsadmin -h wlsadmin -p 7001:7001 12213-domain


$ docker run -d -e ADMIN_USERNAME=weblogic -e ADMIN_PASSWORD=welcome1 -e DOMAIN_HOME=/u01/oracle/user_projects/domains/abc_domain -e DOMAIN_NAME=abc_domain oracle/weblogic:12.2.1.3-developer

mriccell · 2018-04-20T22:52:36Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+Note: you can also mount the file directly as follows.
+
+        $ docker run -v /scratch/apache-config/custom_mod_wl_apache.conf:/config/custom_mod_wl_apache.conf -w /config -d -e WEBLOGIC_HOST=<admin-host> -e WEBLOGIC_PORT=7001 -p 80:80 12213-apache


replace /scratch/apache-config/ for host directory a user when they run this command will not have a .scratch directory

mriccell · 2018-04-20T22:52:50Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+This mounting can be done by using the -v option with the `docker run` command as shown below. 
+
+        $ docker run -v /scratch/apache-config:/config -w /config -d -e WEBLOGIC_HOST=<admin-host> -e WEBLOGIC_PORT=7001 -p 80:80 12213-apache


replace /scratch/apache-config/ for host-directory, a user when they run this command will not have a .scratch directory

mriccell · 2018-04-20T22:53:59Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+* Create a `custom_mod_wl_apache.conf` file by referring to `custom_mod_wl_apache.conf.sample` and Chapter 3 @ Fusion Middleware Using Oracle WebLogic Server Proxy Plug-Ins documentation. [https://docs.oracle.com/middleware/12213/webtier/develop-plugin/apache.htm#GUID-231FB5FD-8D0A-492A-BBFD-DC12A31BF2DE]
+
+* Place the `custom_mod_wl_apache.conf` file in a directory on the host machine (for example,`/scratch/apache-config`) and then mount this directory into the container at the location `/config`. By doing so, the contents of host directory `/scratch/apache-config` (and hence `custom_mod_wl_apache.conf`) will become available in the container at the mount point.


replace /scratch/apache-config for host-directory a user when they run this command will not have a scratch directory

this is just an example.

Yes but it is confusing to the user when they do a copy paste. If you indicate that they should replace the string in the command for host-directory on the host where they are running it is clear. Please see how we do it in 12213-domain README.md sample.

mriccell · 2018-04-20T22:57:18Z

OracleWebLogic/samples/12213-webtier-apache/buildDockerImage.sh

+Builds a Docker Image for Oracle HTTP Server (standalone) .
+
+Parameters:
+   -v: Release version to build. Required. E.g 12.2.1.2.0


E.g 12.2.1.3.0

mriccell · 2018-04-20T22:57:39Z

OracleWebLogic/samples/12213-webtier-apache/buildDockerImage.sh

+#!/bin/bash
+#
+# Since: May, 2018
+# Author: prabhat.kishore@oracle.com


you are the author

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

mriccell · 2018-04-21T15:13:41Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+        $ docker run -d -e WEBLOGIC_CLUSTER=host1:port,host2:port,host3:port --net=<some net> -p 80:80 12213-apache
+
+Run an Apache image to proxy and load balance to a list of managed servers in a cluster


I understand the multiple server host:port vs the cluster url. My comment refers to line 25 and line 31 are identical.

mriccell · 2018-04-21T16:55:12Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+### Admin Server Only Example
+
+First make sure you have the WebLogic Server 12.2.1.3 sample and build your own image 12213-domain at [https://github.com/oracle/docker-images/tree/master/OracleWebLogic/samples/12213-domain].


There are two WebLogic topologies we support in Docker, the single Admin server/domain per container which you get from running a container from the WebLogic install image, and the WebLogic domain/cluster with one admin server and multiple clustered managed servers. Your example for the single Admin server should use the WebLogic install image to run an admin server container, the WLST that is used in that image creates a domain with a single admin server. The 12213-domain WLST scripts that get invoked when you run the Admin server container create a WLS domain with an admin server, cluster with multiple managed servers.

mriccell · 2018-04-21T16:58:14Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+* Create a `custom_mod_wl_apache.conf` file by referring to `custom_mod_wl_apache.conf.sample` and Chapter 3 @ Fusion Middleware Using Oracle WebLogic Server Proxy Plug-Ins documentation. [https://docs.oracle.com/middleware/12213/webtier/develop-plugin/apache.htm#GUID-231FB5FD-8D0A-492A-BBFD-DC12A31BF2DE]
+
+* Place the `custom_mod_wl_apache.conf` file in a directory on the host machine (for example,`/scratch/apache-config`) and then mount this directory into the container at the location `/config`. By doing so, the contents of host directory `/scratch/apache-config` (and hence `custom_mod_wl_apache.conf`) will become available in the container at the mount point.


Yes but it is confusing to the user when they do a copy paste. If you indicate that they should replace the string in the command for host-directory on the host where they are running it is clear. Please see how we do it in 12213-domain README.md sample.

…2213-domain sample domain. Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

mriccell

Happy with this PR

mriccell · 2018-04-23T17:09:30Z

OracleWebLogic/samples/12213-webtier-apache/Dockerfile

+COPY custom_mod_wl_apache.conf.sample /config/custom_mod_wl_apache.conf
+COPY container-scripts/* /u01/oracle/container-scripts/
+
+RUN yum install -y unzip && \


Makes sense then you can do a yum remove after you unzip

mriccell · 2018-04-23T17:45:17Z

OracleWebLogic/samples/12213-webtier-apache/Dockerfile

+COPY custom_mod_wl_apache.conf.sample /config/custom_mod_wl_apache.conf
+COPY container-scripts/* /u01/oracle/container-scripts/
+
+RUN yum install -y unzip && \


Doing a yum remove or erase does not make much difference in the image size

rosemarymarano

Download the Generic installer from… (should probably be lower case “g” generic).
Typo: #Note that adding unzip does not noticably (should be noticeably) increase the size of the image

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

Djelibeybi

@mriccell there is a question in this review for you. :) But there are still some best practice changes I think should be made to future proof the image.

Djelibeybi · 2018-04-23T20:09:27Z

OracleWebLogic/samples/12213-webtier-apache/Dockerfile

+
+# Use unzip because the base image does not contain a JDK
+# Note that adding unzip does not noticably increase the size of the image
+RUN yum install -y unzip && \


Please combine these two into a single yum command, i.e. yum install -y unzip httpd

Djelibeybi · 2018-04-23T20:09:48Z

OracleWebLogic/samples/12213-webtier-apache/README.md

+
+## How to Build Apache With Plugin Docker Image
+
+This project offers a Dockerfile for Apache Web Server with Oraacle WebLogic Server Proxy Plugin in standalone mode. To assist in building the images, you can use `buildDockerImage.sh` script. See below for instructions and usage.


Typo: "Oraacle"

Djelibeybi · 2018-04-23T20:11:40Z

OracleWebLogic/samples/12213-webtier-apache/README.md

@@ -0,0 +1,95 @@
+Apache Web Server with Oracle WebLogic Server Proxy Plugin on Docker


@mriccell doesn't it make more sense to call this the "WebLogic Server Proxy Plugin for Apache" image, i.e. make the WebLogic plugin the primary focus, not Apache?

You're the PM, so whatever you say goes, but it just seems weird to me to have all this Apache stuff when really it's about the WebLogic plugin bits. :)

Djelibeybi · 2018-04-23T20:22:05Z

OracleWebLogic/samples/12213-webtier-apache/Dockerfile

+    unzip /tmp/$PLUGINS_PKG -d /tmp && \
+    unzip /tmp/$PLUGIN_PKG -d $PLUGIN_HOME && \
+    cat /tmp/httpd.conf > /etc/httpd/conf/httpd.conf  && \
+    cat /tmp/weblogic.conf >> /etc/httpd/conf/httpd.conf  && \


Don't do this. Just create the weblogic.conf file in directly in /etc/httpd/conf.d/.

Djelibeybi · 2018-04-23T20:22:47Z

OracleWebLogic/samples/12213-webtier-apache/Dockerfile

+    unzip /tmp/$FMW_PKG -d /tmp && \
+    unzip /tmp/$PLUGINS_PKG -d /tmp && \
+    unzip /tmp/$PLUGIN_PKG -d $PLUGIN_HOME && \
+    cat /tmp/httpd.conf > /etc/httpd/conf/httpd.conf  && \


Why are you replacing the default configuration file for Apache? Can you point me towards the changes you make to the file so we can use awk or sed instead?

Fixed - use sed.

Djelibeybi · 2018-04-23T20:24:47Z

OracleWebLogic/samples/12213-webtier-apache/container-scripts/run-httpd.sh

+
+exec httpd -DFOREGROUND
+
+tail -f /var/log/httpd/access_log


Why are you doing this if you're running httpd in FOREGROUND mode? This shouldn't be necessary (and is not used in the upstream httpd image either).

Djelibeybi · 2018-04-23T20:25:12Z

OracleWebLogic/samples/12213-webtier-apache/httpd.conf

@@ -0,0 +1,362 @@
+#
+# This is the main Apache HTTP server configuration file.  It contains the


As mentioned above, it's bad practice to replace an entire file. Rather, you should just change individual settings as needed.

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

Djelibeybi

Please remove httpd.conf from the git repo as it's no longer used. Once that's done, I will approve this PR and merge it.

Djelibeybi · 2018-04-23T21:42:19Z

Merged. Thanks for your prompt response to our reviews!

doxiao · 2018-04-23T21:43:15Z

Thanks for the valuable comments from all of you!

doxiao added 2 commits April 18, 2018 10:11

Add a docker image for Apache web tier with WebLogic 12.2.1.3.0 Plugin

de26357

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

Minor fixes to README.md

c196a0f

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

doxiao requested a review from mriccell as a code owner April 18, 2018 17:53

mriccell requested changes Apr 18, 2018

View reviewed changes

doxiao added 2 commits April 18, 2018 12:17

Address PR review comments and add advanced use cases

de017d3

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

A Minor fix to README.md

40bf8f3

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

Djelibeybi self-requested a review April 18, 2018 23:07

Djelibeybi self-assigned this Apr 18, 2018

Djelibeybi requested changes Apr 18, 2018

View reviewed changes

mriccell reviewed Apr 18, 2018

View reviewed changes

Djelibeybi requested changes Apr 19, 2018

View reviewed changes

doxiao added 3 commits April 20, 2018 15:18

Address review comments.

961b3a3

1) use oraclelinux:7-slim as the base 2) repalce build.sh and build_internal.sh with buildDockerImage.sh 3) updated README.md Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

Minor change to README.md

86a6c37

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

More changes to README.md

88be537

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

mriccell requested changes Apr 20, 2018

View reviewed changes

Address review comments

190f419

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

mriccell requested changes Apr 21, 2018

View reviewed changes

doxiao added 5 commits April 22, 2018 16:13

Change the example to use store/oracle/weblogic:12.2.1.3 instead of 1…

4cbd25a

…2213-domain sample domain. Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

Remove the "Support" section in README.

ffeae2a

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

Remove mentioning of JDK plus minor fixes.

48d0f25

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

Remove --net option.

3696645

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

Add a comment in Dockerfile for the reason we use unzip

a93aa99

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

mriccell previously approved these changes Apr 23, 2018

View reviewed changes

rosemarymarano reviewed Apr 23, 2018

View reviewed changes

Fix typos in Dockerfile

3535e01

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

doxiao dismissed mriccell’s stale review via 3535e01 April 23, 2018 20:14

mriccell previously approved these changes Apr 23, 2018

View reviewed changes

Djelibeybi requested changes Apr 23, 2018

View reviewed changes

Address review comments from Avi

04dbc92

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

doxiao dismissed mriccell’s stale review via 04dbc92 April 23, 2018 21:26

Remove httpf.conf

a9ecffa

Signed-off-by: Dongbo Xiao <dongbo.xiao@oracle.com>

Djelibeybi requested changes Apr 23, 2018

View reviewed changes

Djelibeybi approved these changes Apr 23, 2018

View reviewed changes

Djelibeybi merged commit 3437768 into oracle:master Apr 23, 2018


		$ sh build.sh

		Oracle developers can use build_internal.sh, which set up HTTP/HTTPS proxies.


		The values of WEBLOGIC_CLUSTER must be valid, existing containers running WebLogic servers.

		## Example


		$ docker run -d -e WEBLOGIC_CLUSTER=host1:port,host2:port,host3:port --net=<some net> -p 80:80 12213-apache

		The values of WEBLOGIC_CLUSTER must be valid, existing containers running WebLogic servers.


		Now you can access the WebLogic Admin Console under http://localhost/console (default to port 80) instead of using port 7001.

		If you are using multihost network, remove --link and set "--net=<your net>".


		If you are using multihost network, remove --link and set "--net=<your net>".

		## Advanced Use Cases


		If you want to start the Apache container with some pre-specified mod_weblogic configuration:

		* Depending on your weblogic environment , create a custom_mod_wl_apache.conf file by referring to custom_mod_wl_apache.conf.sample and Chapter 3 @ Fusion Middleware Using Oracle WebLogic Server Proxy Plug-Ins documentation.


		* Depending on your weblogic environment , create a custom_mod_wl_apache.conf file by referring to custom_mod_wl_apache.conf.sample and Chapter 3 @ Fusion Middleware Using Oracle WebLogic Server Proxy Plug-Ins documentation.

		* Place the custom_mod_wl_apache.conf file in a directory in the host, (for example, "/scratch/DockerVolume/ApacheVolume"), and then mount this directory into the container at the location "/config". By doing so, the contents of host directory /scratch/DockerVolume/ApacheVolume(and hence custom_mod_wl_apache.conf) will become available in the container at the mount point.

		This mounting can be done by using the -v option with the 'docker run' command as shown below.

		$ docker run -v /scratch/DockerVolume/ApacheVolume:/config -w /config -d -e WEBLOGIC_HOST=<admin-host> -e WEBLOGIC_PORT=7001 -p 80:80 12213-apache


		If you need to set up HTTP/HTTPS proxies, build the image using script build_internal.sh.

		$ sh build_internal.sh


		Run an Apache container to access an admin server that is running on <host> and listening to <port>.

		$ docker run -d -e WEBLOGIC_HOST=i<host> WEBLOGIC_PORT=<port> -p 80:80 12213-apache


		$ docker run -d -e WEBLOGIC_CLUSTER=host1:port,host2:port,host3:port --net=<some net> -p 80:80 12213-apache

		Run an Apache image to proxy and load balance to a list of managed servers in a cluster


		### Admin Server Only Example

		First make sure you have the WebLogic Server 12.2.1.3 sample and build your own image 12213-domain at [https://github.com/oracle/docker-images/tree/master/OracleWebLogic/samples/12213-domain].


		To start a containerized Admin Server, run:

		$ docker run -d --name wlsadmin -h wlsadmin -p 7001:7001 12213-domain


		Note: you can also mount the file directly as follows.

		$ docker run -v /scratch/apache-config/custom_mod_wl_apache.conf:/config/custom_mod_wl_apache.conf -w /config -d -e WEBLOGIC_HOST=<admin-host> -e WEBLOGIC_PORT=7001 -p 80:80 12213-apache


		This mounting can be done by using the -v option with the `docker run` command as shown below.

		$ docker run -v /scratch/apache-config:/config -w /config -d -e WEBLOGIC_HOST=<admin-host> -e WEBLOGIC_PORT=7001 -p 80:80 12213-apache


		* Create a `custom_mod_wl_apache.conf` file by referring to `custom_mod_wl_apache.conf.sample` and Chapter 3 @ Fusion Middleware Using Oracle WebLogic Server Proxy Plug-Ins documentation. [https://docs.oracle.com/middleware/12213/webtier/develop-plugin/apache.htm#GUID-231FB5FD-8D0A-492A-BBFD-DC12A31BF2DE]

		* Place the `custom_mod_wl_apache.conf` file in a directory on the host machine (for example,`/scratch/apache-config`) and then mount this directory into the container at the location `/config`. By doing so, the contents of host directory `/scratch/apache-config` (and hence `custom_mod_wl_apache.conf`) will become available in the container at the mount point.


		## How to Build Apache With Plugin Docker Image

		This project offers a Dockerfile for Apache Web Server with Oraacle WebLogic Server Proxy Plugin in standalone mode. To assist in building the images, you can use `buildDockerImage.sh` script. See below for instructions and usage.

		@@ -0,0 +1,95 @@
		Apache Web Server with Oracle WebLogic Server Proxy Plugin on Docker

		@@ -0,0 +1,362 @@
		#
		# This is the main Apache HTTP server configuration file. It contains the

Add 12213 Docker image sample for Apache with WebLogic 12.2.1.3.0 Proxy Plugin #849

Add 12213 Docker image sample for Apache with WebLogic 12.2.1.3.0 Proxy Plugin #849

Conversation

doxiao commented Apr 18, 2018 • edited Loading

mriccell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Djelibeybi commented Apr 18, 2018

Djelibeybi left a comment

Choose a reason for hiding this comment

Djelibeybi Apr 18, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Djelibeybi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mriccell commented Apr 19, 2018

Djelibeybi commented Apr 20, 2018 • edited Loading

mriccell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mriccell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rosemarymarano left a comment

Choose a reason for hiding this comment

Djelibeybi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

doxiao commented Apr 18, 2018 •

edited

Loading

Djelibeybi Apr 18, 2018 •

edited

Loading

Djelibeybi commented Apr 20, 2018 •

edited

Loading