Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in New Module templates #1415

Closed
leigh-pointer opened this issue May 29, 2021 · 4 comments
Closed

Errors in New Module templates #1415

leigh-pointer opened this issue May 29, 2021 · 4 comments

Comments

@leigh-pointer
Copy link
Contributor

When selecting Framework version 2.0.2 module created is not compatible with 2.1.0

@sbwalker
Copy link
Member

the new module template relies on features in 2.1.0

@sbwalker
Copy link
Member

You do raise a good point in this issue though as the Module Creator UI allows you to select from a list of versions - not all of which are compatible with the template. It seems there needs to be a way for a template to indicate the minimum version it supports. The simplest solution would be to specify it as part of the template folder name

@leigh-pointer
Copy link
Contributor Author

@sbwalker was think about that myself. I think for simplicity, the best way would be to use the folder name.

@sbwalker
Copy link
Member

@leigh-pointer see #1425 which adds support for a template.json file for a module or theme template - this enhancement provides a number of benefits including friendlier naming of templates in UI, specifying minimum framework version compatibility, indicating if a template is External or Internal, and providing the server root location so that the Client no longer needs to reference System.IO or SystemInfo service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants