Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fontawesome + Oqtane question #1007

Closed
tanekim88 opened this issue Dec 18, 2020 · 2 comments
Closed

Fontawesome + Oqtane question #1007

tanekim88 opened this issue Dec 18, 2020 · 2 comments

Comments

@tanekim88
Copy link

tanekim88 commented Dec 18, 2020

I am seeing that Page class has an Icon property, and it specifies an Open Iconic name.

If I want to use icon that is not available in Open Iconic, is there a way to do so?

Is there way for me to include extra property like public string FontAwesomeIcon {get; set;} in Page class without modifying Page.cs? In this way, when I am creating a custom theme, I can use whatever icon that is available to display, either from Page.FontAwesomeIcon or from Page.Icon.

@sbwalker
Copy link
Member

Currently Oqtane supports Open Iconic. We will not be distributing any additional icon libraries as part of the framework as it goes against our Philosophy ( https://www.oqtane.org/Resources/Blog/PostId/538/oqtane-philosophy ) related to third party dependencies. The Page property for Icon should probably not be tightly coupled to Open Iconic so that it is possible to use other icon libraries. This will require modifications to the framework.

@sbwalker
Copy link
Member

#1009 removes the hard dependency on Open Iconic and allows you to use other icon libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants