Skip to content

Conversation

@andrewleap-optimizely
Copy link
Contributor

Summary

Provides an internal service for ODP graphQL server access.

  • Supports fetching segments from the ODP server.

Tests

Added:

  • zaius_graphql_api_manager_spec.rb

Ticket

OASIS-8434

@andrewleap-optimizely andrewleap-optimizely marked this pull request as ready for review August 8, 2022 14:55
@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner August 8, 2022 14:55
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. A couple of small changes suggested.

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewleap-optimizely andrewleap-optimizely merged commit 5a2ae4e into master Aug 9, 2022
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/add_graphql_api branch August 9, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants