Skip to content

Commit d754e62

Browse files
committed
resolves missing params issue
1 parent 241737d commit d754e62

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

spec/event_builder_spec.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -386,6 +386,13 @@
386386
# with right params when user agent attribute is provided and
387387
# bot filtering is enabled
388388

389+
@expected_impression_params[:visitors][0][:attributes] = [{
390+
entity_id: Optimizely::Helpers::Constants::CONTROL_ATTRIBUTES['BOT_FILTERING'],
391+
key: Optimizely::Helpers::Constants::CONTROL_ATTRIBUTES['BOT_FILTERING'],
392+
type: 'custom',
393+
value: true
394+
}]
395+
389396
@expected_impression_params[:visitors][0][:attributes].unshift(
390397
entity_id: Optimizely::Helpers::Constants::CONTROL_ATTRIBUTES['USER_AGENT'],
391398
key: Optimizely::Helpers::Constants::CONTROL_ATTRIBUTES['USER_AGENT'],
@@ -396,6 +403,7 @@
396403
'$opt_user_agent' => 'test'
397404
}
398405
experiment = config.get_experiment_from_key('test_experiment')
406+
expect(@event_builder.send(:bot_filtering)).to eq(true)
399407
impression_event = @event_builder.create_impression_event(experiment, '111128', 'test_user', user_attributes)
400408
expect(impression_event.params).to eq(@expected_impression_params)
401409
expect(impression_event.url).to eq(@expected_endpoint)

0 commit comments

Comments
 (0)