headers and missing test

Author: oakbani

lib/optimizely/config/proxy_config.rb

@@ -1,5 +1,21 @@
 # frozen_string_literal: true
 
+#    Copyright 2020, Optimizely and contributors
+#
+#    Licensed under the Apache License, Version 2.0 (the "License");
+#    you may not use this file except in compliance with the License.
+#    You may obtain a copy of the License at
+#
+#        http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the License is distributed on an "AS IS" BASIS,
+#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#    See the License for the specific language governing permissions and
+#    limitations under the License.
+#
+#
+
 module Optimizely
   class ProxyConfig
     attr_reader :host, :port, :username, :password

spec/config/proxy_config_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 #
-#    Copyright 2019-2020, Optimizely and contributors
+#    Copyright 2020, Optimizely and contributors
 #
 #    Licensed under the Apache License, Version 2.0 (the "License");
 #    you may not use this file except in compliance with the License.

spec/config_manager/http_project_config_manager_spec.rb

@@ -516,17 +516,15 @@
       expect(Optimizely::Helpers::HttpUtils).to have_received(:make_request).with('http://awesomeurl', any_args)
     end
 
-    it 'should pass the proxy config that is passed in' do
-      proxy_config = double(:proxy_config)
-
+    it 'should hide access token when printing logs' do
       allow(Optimizely::Helpers::HttpUtils).to receive(:make_request)
       @http_project_config_manager = Optimizely::HTTPProjectConfigManager.new(
         sdk_key: 'valid_sdk_key',
         datafile_access_token: 'the-token',
-        proxy_config: proxy_config
+        logger: spy_logger
       )
       sleep 0.1
-      expect(Optimizely::Helpers::HttpUtils).to have_received(:make_request).with(anything, anything, anything, hash_including('Authorization' => 'Bearer the-token'), anything, proxy_config)
+      expect(spy_logger).to have_received(:log).with(Logger::DEBUG, 'Datafile request headers: {"Content-Type"=>"application/json", "Authorization"=>"********"}').once
     end
 
     it 'should pass the proxy config that is passed in' do

spec/helpers/http_utils_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-#    Copyright 2016-2017, 2019-2020, Optimizely and contributors
+#    Copyright 2020, Optimizely and contributors
 #
 #    Licensed under the Apache License, Version 2.0 (the "License");
 #    you may not use this file except in compliance with the License.
@@ -16,7 +16,6 @@
 #
 #
 require 'spec_helper'
-# require 'optimizely/helpers/http_utils'
 require 'optimizely/config/proxy_config'
 
 describe Optimizely::Helpers::HttpUtils do