Skip to content

ci: hook fullstack-prod-suite on travis #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 28, 2020
Merged

ci: hook fullstack-prod-suite on travis #280

merged 6 commits into from
Jul 28, 2020

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Jul 7, 2020 •
edited by msohailhussain
Loading

Summary

This PR hooks Fullstack Prod Suite build on Travis.

Test plan

Added FPS Check which should be passed

@coveralls
Copy link

coveralls commented Jul 7, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 97.154% when pulling 4e9e326 on oakbani/hook-fps into 3417408 on master.

msohailhussain
msohailhussain approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain msohailhussain marked this pull request as ready for review July 16, 2020 21:49
@msohailhussain msohailhussain requested a review from a team as a code owner July 16, 2020 21:49
msohailhussain
msohailhussain approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 reopened this Jul 20, 2020
mikeproeng37
mikeproeng37 approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit a601426 into master Jul 28, 2020
@mikeproeng37 mikeproeng37 deleted the oakbani/hook-fps branch July 28, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees

@oakbani oakbani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oakbani @coveralls @mikeproeng37 @msohailhussain @optimizely-codereview-bot