Skip to content

fix(Polling Manager): Fixing how config manager blocks. Miscellaneous other fixes as well. #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 24, 2019
Merged

fix(Polling Manager): Fixing how config manager blocks. Miscellaneous other fixes as well. #216

merged 6 commits into from
Oct 24, 2019

Conversation

aliabbasrizvi
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi commented Oct 24, 2019 •
edited
Loading

Summary

  • The polling config manager is supposed to wait until config is ready. Previously, the config will be attempted to be initialized with empty datafile. This was resolved by overriding up _set_config in PollingConfigManager.
  • Config ready event had no business in StaticConfigManager so it has been moved from there.
  • Some formatting and other miscellaneous fixes.

@aliabbasrizvi aliabbasrizvi requested a review from a team as a code owner October 24, 2019 05:46
@aliabbasrizvi aliabbasrizvi removed their assignment Oct 24, 2019
mjc1283
mjc1283 approved these changes Oct 24, 2019
View reviewed changes
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 97.539% when pulling 153e8f9 on ali/multiple_fixes into 77ec185 on master.

@coveralls
Copy link

coveralls commented Oct 24, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 97.696% when pulling b2eb96c on ali/multiple_fixes into 77ec185 on master.

msohailhussain
msohailhussain approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

optimizely/event/event_processor.py
self._DEFAULT_TIMEOUT_INTERVAL) \
else timedelta(self._DEFAULT_TIMEOUT_INTERVAL)

self.notification_center = notification_center or _notification_center.NotificationCenter(self.logger)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helps us get rid of conditionals later on.

@aliabbasrizvi aliabbasrizvi merged commit 03e61ad into master Oct 24, 2019
@aliabbasrizvi aliabbasrizvi deleted the ali/multiple_fixes branch October 24, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

@msohailhussain msohailhussain msohailhussain approved these changes

@pawels-optimizely pawels-optimizely pawels-optimizely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aliabbasrizvi @coveralls @mjc1283 @msohailhussain @pawels-optimizely