Skip to content

Conversation

@muzahidul-opti
Copy link
Contributor

@muzahidul-opti muzahidul-opti commented Oct 28, 2025

Summary

  • Add FlutterLogbackAppender to intercept sdk's log and pass through flutter channel.
  • Inject default logger to make the behavior consistent between iOS and Android.

Test plan

  • All test cases should be passed

Issues

  • FSSDK-11985

- Add FlutterLogbackAppender.java for logging events in the Flutter app
- Integrate OptimizelyFlutterSdkPlugin with FlutterLogbackAppender
- Update Constants.swift, SwiftOptimizelyFlutterSdkPlugin.swift, and related classes
- Adjust method to correctly convert log level strings to integers
- Refactor switch statement for better readability and maintainability
- Remove unnecessary default log level value initialization
- Refactor switch statement to directly return log levels for each case
- Simplify comparison for warning log levels to include both "WARN" and "WARNING"
- Comment out configuration block in logback.xml
- Modify log level 'WARNING' to 'WARN' in FlutterLogbackAppender.java
- Add check for kDebugMode to control printing of logs
@muzahidul-opti muzahidul-opti changed the title Support andorid logger [FSSDK-11985] feat: add android logger support Oct 28, 2025
@muzahidul-opti muzahidul-opti marked this pull request as ready for review October 28, 2025 13:21
@muzahidul-opti muzahidul-opti requested a review from jaeopt October 28, 2025 13:21
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I do not see customLogger injection for android side?

- Comment out old logback configuration
- Add note explaining the use of FlutterLogbackAppender for logging
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti merged commit 9dfbcec into master Oct 29, 2025
9 checks passed
@muzahidul-opti muzahidul-opti deleted the support-andorid-logger branch October 29, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants