[APPX-4007] - Placeholder personal access tokens (PAT's). #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdarias3
approved these changes
May 24, 2022
lshofmann
approved these changes
Sep 12, 2022
|
@edkloczko is this only waiting on being unable to merge due to branch protection rules? |
@lshofmann Yes, exactly! Would be awesome if you could open up the settings on this repo a bit, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tokens came up in a bug bounty ticket APPX-4007. I understand that there's no real harm here because the AWS credentials are read-only for objects relating to this project, but I have been given guidance to revoke the tokens & add placeholders (knowing that this doesn't re-write the
githistory, which is why they're also being revoked).