Skip to content

Input validation in Activate, Track and GetVariation methods. #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 8, 2018

Conversation

mfahadahmed
Copy link
Contributor

No description provided.

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a __validateInputs method. Can you use that instead of creating another method to validate null values?

@mfahadahmed
Copy link
Contributor Author

@mikeng13, we currently have two different validators (user_id_validator and string_value_validator) which are doing the same task of validating string inputs.
Should I remove the user_id_validator and validate User ID with string_value_validator? Then we can easily change the first parameter of __validateInputs to string values map.

@mikeproeng37
Copy link
Contributor

@mfahadahmed you can repurpose the __validateInputs method (refactor) to take in the values arg and perform all the needed validation inside of that method, including null checks.

@mfahadahmed
Copy link
Contributor Author

@mikeng13, The required changes have been done. Please verify.

@mikeproeng37
Copy link
Contributor

build

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 7988063 into master May 8, 2018
@mikeproeng37 mikeproeng37 deleted the fahad/null-input-validation branch September 7, 2018 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants